Skip to content

Conversation

@aaronccasanova
Copy link
Member

@aaronccasanova aaronccasanova commented Sep 24, 2022

WHAT is this pull request doing?

This PR upgrades the root TypeScript version to v4.9.3 and performs minimal changes to address build failures.

TODO:

  • Create snapshot release
  • Tophat the Admin

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

Copy-paste this code in playground/Playground.tsx:
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}

🎩 checklist

@github-actions
Copy link
Contributor

github-actions bot commented Sep 24, 2022

size-limit report 📦

Path Size
polaris-react-cjs 215.93 KB (-0.02% 🔽)
polaris-react-esm 137.24 KB (-0.03% 🔽)
polaris-react-esnext 191.57 KB (-0.02% 🔽)
polaris-react-css 41.03 KB (0%)

@aaronccasanova
Copy link
Member Author

/snapit

@github-actions
Copy link
Contributor

🫰✨ Thanks @aaronccasanova! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @shopify/plugin-polaris@0.0.0-snapshot-release-20220927023508
yarn add @shopify/polaris@0.0.0-snapshot-release-20220927023508

sam-b-rose
sam-b-rose previously approved these changes Sep 27, 2022
Copy link
Member

@sam-b-rose sam-b-rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for keeping this updated ⬆️ 👍 looks good so far

@aaronccasanova aaronccasanova changed the title Upgrade TypeScript to v4.8.3 Upgrade TypeScript to v4.9.3 Nov 30, 2022
@aaronccasanova
Copy link
Member Author

/snapit

@aaronccasanova aaronccasanova marked this pull request as ready for review November 30, 2022 06:57
@github-actions
Copy link
Contributor

🫰✨ Thanks @aaronccasanova! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @shopify/plugin-polaris@0.0.0-snapshot-release-20221130070005
yarn add @shopify/polaris-icons@0.0.0-snapshot-release-20221130070005
yarn add @shopify/polaris-migrator@0.0.0-snapshot-release-20221130070005
yarn add @shopify/polaris@0.0.0-snapshot-release-20221130070005

@aaronccasanova aaronccasanova mentioned this pull request Nov 30, 2022
7 tasks
laurkim and others added 4 commits February 1, 2023 13:03
### WHY are these changes introduced?

Added a section to Design/Typography in the style guide to call out that
the design system no longer supports uppercase typography styles.

### WHAT is this pull request doing?

<img width="1353" alt="01-30-evh8p-8m14u"
src="https://user-images.githubusercontent.com/26749317/216118646-fafc6bda-4044-4e94-a25e-6157ac361485.png">

### How to 🎩

🖥 [Local development
instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development)
🗒 [General tophatting
guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md)
📄 [Changelog
guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)

### 🎩 checklist

- [ ] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [ ] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [x] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide

---------

Co-authored-by: aveline <aveline@users.noreply.github.com>
@alex-page alex-page changed the base branch from main to rm-dldts February 2, 2023 03:32
@alex-page alex-page dismissed sam-b-rose’s stale review February 2, 2023 03:32

The base branch was changed.

@alex-page alex-page added the 🤖Skip Changelog Causes CI to ignore changelog update check. label Feb 2, 2023
@alex-page alex-page merged commit 4a81059 into rm-dldts Feb 2, 2023
@alex-page alex-page deleted the upgrade-typescript branch February 2, 2023 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖Skip Changelog Causes CI to ignore changelog update check.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants