- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1.2k
Upgrade TypeScript to v4.9.3 #7271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| size-limit report 📦
 | 
| /snapit | 
| 🫰✨ Thanks @aaronccasanova! Your snapshots have been published to npm. Test the snapshots by updating your  yarn add @shopify/plugin-polaris@0.0.0-snapshot-release-20220927023508yarn add @shopify/polaris@0.0.0-snapshot-release-20220927023508 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for keeping this updated ⬆️ 👍 looks good so far
| /snapit | 
| 🫰✨ Thanks @aaronccasanova! Your snapshots have been published to npm. Test the snapshots by updating your  yarn add @shopify/plugin-polaris@0.0.0-snapshot-release-20221130070005yarn add @shopify/polaris-icons@0.0.0-snapshot-release-20221130070005yarn add @shopify/polaris-migrator@0.0.0-snapshot-release-20221130070005yarn add @shopify/polaris@0.0.0-snapshot-release-20221130070005 | 
### WHY are these changes introduced? Added a section to Design/Typography in the style guide to call out that the design system no longer supports uppercase typography styles. ### WHAT is this pull request doing? <img width="1353" alt="01-30-evh8p-8m14u" src="https://user-images.githubusercontent.com/26749317/216118646-fafc6bda-4044-4e94-a25e-6157ac361485.png"> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide --------- Co-authored-by: aveline <aveline@users.noreply.github.com>
WHAT is this pull request doing?
This PR upgrades the root TypeScript version to
v4.9.3and performs minimal changes to address build failures.TODO:
How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
Copy-paste this code in
playground/Playground.tsx:🎩 checklist
README.mdwith documentation changes