[polaris.shopify.com] Add content for uppercase typography #8235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aveline
approved these changes
Feb 1, 2023
Co-authored-by: aveline <aveline@users.noreply.github.com>
Merged
laurkim
pushed a commit
that referenced
this pull request
Feb 2, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris@10.25.0 ### Minor Changes - [#7950](#7950) [`286c63a84`](286c63a) Thanks [@laurkim](https://github.com/laurkim)! - Updated `Tabs` component to use layout primitives - [#7950](#7950) [`286c63a84`](286c63a) Thanks [@laurkim](https://github.com/laurkim)! - Updated `OptionList` to use new layout primitives - [#7950](#7950) [`286c63a84`](286c63a) Thanks [@laurkim](https://github.com/laurkim)! - Updated `Popover` to use new layout primitives ### Patch Changes - [#7950](#7950) [`286c63a84`](286c63a) Thanks [@laurkim](https://github.com/laurkim)! - Remove unused class in Page Header - [#7950](#7950) [`286c63a84`](286c63a) Thanks [@laurkim](https://github.com/laurkim)! - Rebuilt Page Header with layout components - [#8237](#8237) [`17fa970db`](17fa970) Thanks [@loic-d](https://github.com/loic-d)! - Fixed Backdrop onClick callback when setClosing is missing ## @shopify/polaris-cli@0.1.1 ## polaris.shopify.com@0.31.1 ### Patch Changes - [#8235](#8235) [`5fbe75461`](5fbe754) Thanks [@laurkim](https://github.com/laurkim)! - Updated Patterns/Typography copy to include suggestions for uppercase typography styles - Updated dependencies \[[`286c63a84`](286c63a), [`286c63a84`](286c63a), [`286c63a84`](286c63a), [`286c63a84`](286c63a), [`286c63a84`](286c63a), [`17fa970db`](17fa970)]: - @shopify/polaris@10.25.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Merged
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
) ### WHY are these changes introduced? Added a section to Design/Typography in the style guide to call out that the design system no longer supports uppercase typography styles. ### WHAT is this pull request doing? <img width="1353" alt="01-30-evh8p-8m14u" src="https://user-images.githubusercontent.com/26749317/216118646-fafc6bda-4044-4e94-a25e-6157ac361485.png"> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide --------- Co-authored-by: aveline <aveline@users.noreply.github.com>
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris@10.25.0 ### Minor Changes - [Shopify#7950](Shopify#7950) [`286c63a84`](Shopify@286c63a) Thanks [@laurkim](https://github.com/laurkim)! - Updated `Tabs` component to use layout primitives - [Shopify#7950](Shopify#7950) [`286c63a84`](Shopify@286c63a) Thanks [@laurkim](https://github.com/laurkim)! - Updated `OptionList` to use new layout primitives - [Shopify#7950](Shopify#7950) [`286c63a84`](Shopify@286c63a) Thanks [@laurkim](https://github.com/laurkim)! - Updated `Popover` to use new layout primitives ### Patch Changes - [Shopify#7950](Shopify#7950) [`286c63a84`](Shopify@286c63a) Thanks [@laurkim](https://github.com/laurkim)! - Remove unused class in Page Header - [Shopify#7950](Shopify#7950) [`286c63a84`](Shopify@286c63a) Thanks [@laurkim](https://github.com/laurkim)! - Rebuilt Page Header with layout components - [Shopify#8237](Shopify#8237) [`17fa970db`](Shopify@17fa970) Thanks [@loic-d](https://github.com/loic-d)! - Fixed Backdrop onClick callback when setClosing is missing ## @shopify/polaris-cli@0.1.1 ## polaris.shopify.com@0.31.1 ### Patch Changes - [Shopify#8235](Shopify#8235) [`5fbe75461`](Shopify@5fbe754) Thanks [@laurkim](https://github.com/laurkim)! - Updated Patterns/Typography copy to include suggestions for uppercase typography styles - Updated dependencies \[[`286c63a84`](Shopify@286c63a), [`286c63a84`](Shopify@286c63a), [`286c63a84`](Shopify@286c63a), [`286c63a84`](Shopify@286c63a), [`286c63a84`](Shopify@286c63a), [`17fa970db`](Shopify@17fa970)]: - @shopify/polaris@10.25.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Added a section to Design/Typography in the style guide to call out that the design system no longer supports uppercase typography styles.
WHAT is this pull request doing?
How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
🎩 checklist
README.mdwith documentation changes