Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mini-oxygen dependency #1932

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Remove mini-oxygen dependency #1932

merged 2 commits into from
Apr 4, 2024

Conversation

frandiox
Copy link
Contributor

@frandiox frandiox commented Apr 1, 2024

I forgot to remove mini-oxygen from the CLI's direct dependencies in #1891 (it's now a peer dep) . Also adding some minor cleanup to this PR.

@frandiox frandiox requested a review from a team April 1, 2024 14:31
Copy link
Contributor

github-actions bot commented Apr 1, 2024

We detected some changes in packages/*/package.json or packages/*/src, and there are no updates in the .changeset.
If the changes are user-facing and should cause a version bump, run npm run changeset add to track your changes and include them in the next release CHANGELOG.
If you are making simple updates to examples or documentation, you do not need to add a changeset.

Copy link
Contributor

shopify bot commented Apr 1, 2024

Oxygen deployed a preview of your fd-mini-oxygen-dep branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
subscriptions ✅ Successful (Logs) Preview deployment Inspect deployment April 1, 2024 2:32 PM
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment April 1, 2024 2:32 PM
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment April 1, 2024 2:32 PM
vite ✅ Successful (Logs) Preview deployment Inspect deployment April 1, 2024 2:32 PM
skeleton ✅ Successful (Logs) Preview deployment Inspect deployment April 1, 2024 2:32 PM
optimistic-cart-ui ✅ Successful (Logs) Preview deployment Inspect deployment April 1, 2024 2:32 PM

Learn more about Hydrogen's GitHub integration.

@frandiox frandiox changed the title Remox mini-oxygen dependency Remove mini-oxygen dependency Apr 1, 2024
@frandiox frandiox merged commit 479dbaa into main Apr 4, 2024
13 checks passed
@frandiox frandiox deleted the fd-mini-oxygen-dep branch April 4, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants