Extract workerd logic in mini-oxygen package #1891
Conversation
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
| "@types/recursive-readdir": "^2.2.1", | ||
| "@types/stack-trace": "^0.0.30", |
There was a problem hiding this comment.
So this is what you were saying yesterday, all of these deps can be removed from the CLI, which will make npm create @shopify/hydrogen faster? And instead they are deps to the new package, which is a peer dep.
There was a problem hiding this comment.
Yeah. The main dependency here is miniflare (123MB): https://pkg-size.dev/miniflare@3
Now this is only installed when doing npm i in the template, not when the CLI is installed globally with npm create @shopify/hydrogen.
| const liveReload = shouldLiveReload | ||
| ? await setupLiveReload(remixConfig.dev?.port ?? 8002) | ||
| : undefined; |
There was a problem hiding this comment.
Worth being a part of the changeset?
There was a problem hiding this comment.
I don't think so, this is only used in the tests to make them more robust (it failed if you already had a dev server up locally because port 8002 is occupied).
Fixed 👍 |
This PR moves shared logic related to workerd into
@shopify/mini-oxygen. This package used to contain the Node.js sandbox logic and it was soft-deprecated. With these changes, it now contains both Node.js sandbox and workerd runtimes. Some of the benefits: