Remove unnecessary awaits

[isaacroldan]

WHY are these changes introduced?

Clean up unnecessary awaits

WHAT is this pull request doing?

• Removes all await keywords when calling normalizeStoreFqdn

How to test your changes?

1. Nothing to test, just that CI passes

Measuring impact

How do we know this change was effective? Please choose one:

• n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix

Checklist

• I've considered possible cross-platform impacts (Mac, Linux, Windows)
• I've considered possible documentation changes

[isaacroldan]

• Remove unnecessary awaits #6431 👈 (View in Graphite)
• Fix dev stores with custom domains #6430
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

Caution

DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.

[github-actions]

Coverage report

St.❔	Category	Percentage	Covered / Total
🟡	Statements	78.95% (+0.15% 🔼)	13308/16856
🟡	Branches	72.63% (-0.04% 🔻)	6497/8945
🟡	Functions	79.15% (+0.33% 🔼)	3440/4346
🟡	Lines	79.31% (+0.17% 🔼)	12570/15850

Show new covered files 🐣

St.❔	File	Statements	Branches	Functions	Lines
🟡	... / type-generation.ts	71%	52.05%	88.89%	70.71%

Show files with reduced coverage 🔻

St.❔	File	Statements	Branches	Functions	Lines
🟢	... / ui_extension.ts	94.78% (-1.3% 🔻)	82.89% (-5.51% 🔻)	100%	96.43% (-1.53% 🔻)
🟢	... / extension.ts	91.11% (+0.58% 🔼)	74% (-0.07% 🔻)	91.67% (-0.33% 🔻)	90.91% (+0.59% 🔼)
🟢	... / conf-store.ts	100%	82.22% (-2.22% 🔻)	100%	100%
🔴	... / environment.ts	40% (-5% 🔻)	41.18%	50% (-10% 🔻)	42.11% (-5.26% 🔻)

Test suite run success

3228 tests passing in 1336 suites.

Report generated by 🧪jest coverage report action from 0f7021c

[plvaldes]

LGTM

There are some warning from ESLint Report Analysis, but not sure they are relevant

[github-actions]

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

• Some seemingly private modules might be re-exported through public modules.
• If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/context/fqdn.d.ts

@@ -50,4 +50,4 @@ export declare function identityFqdn(): Promise<string>;
  * @param store - Store name.
  * @returns Normalized store name.
  */
-export declare function normalizeStoreFqdn(store: string): Promise<string>;
\ No newline at end of file
+export declare function normalizeStoreFqdn(store: string): string;
\ No newline at end of file