Remove unnecessary awaits

Author: isaacroldan

packages/app/src/cli/services/dev/extension/payload/store.ts

@@ -23,8 +23,8 @@ export async function getExtensionsPayloadStoreRawPayload(
     app: {
       title: options.appName,
       apiKey: options.apiKey,
-      url: await buildAppURLForWeb(options.storeFqdn, options.apiKey),
-      mobileUrl: await buildAppURLForMobile(options.storeFqdn, options.apiKey),
+      url: buildAppURLForWeb(options.storeFqdn, options.apiKey),
+      mobileUrl: buildAppURLForMobile(options.storeFqdn, options.apiKey),
     },
     appId: options.id,
     version: options.manifestVersion,

packages/app/src/cli/services/dev/processes/previewable-extension.ts

@@ -60,7 +60,7 @@ export const launchPreviewableExtensionProcess: DevProcessFunction<PreviewableEx
     signal: abortSignal,
     url: proxyUrl,
     port,
-    storeFqdn: await normalizeStoreFqdn(storeFqdn),
+    storeFqdn: normalizeStoreFqdn(storeFqdn),
     storeId,
     apiKey,
     grantedScopes,

packages/app/src/cli/services/dev/processes/setup-dev-processes.ts

@@ -90,7 +90,7 @@ export async function setupDevProcesses({
 }> {
   const apiKey = remoteApp.apiKey
   const apiSecret = remoteApp.apiSecretKeys[0]?.secret ?? ''
-  const appPreviewUrl = await buildAppURLForWeb(storeFqdn, apiKey)
+  const appPreviewUrl = buildAppURLForWeb(storeFqdn, apiKey)
   const env = getEnvironmentVariables()
   const shouldRenderGraphiQL = !isTruthy(env[environmentVariableNames.disableGraphiQLExplorer])
 

packages/app/src/cli/services/store-context.ts

@@ -56,7 +56,7 @@ export async function storeContext({
   }
 
   await logMetadata(selectedStore, forceReselectStore)
-  selectedStore.shopDomain = await normalizeStoreFqdn(selectedStore.shopDomain)
+  selectedStore.shopDomain = normalizeStoreFqdn(selectedStore.shopDomain)
 
   // Save the selected store in the hidden config file
   if (selectedStore.shopDomain !== cachedStoreURL || !devStoreUrlFromHiddenConfig) {

packages/app/src/cli/utilities/app/app-url.ts

@@ -1,12 +1,12 @@
 import {normalizeStoreFqdn} from '@shopify/cli-kit/node/context/fqdn'
 
-export async function buildAppURLForWeb(storeFqdn: string, apiKey: string) {
-  const normalizedFQDN = await normalizeStoreFqdn(storeFqdn)
+export function buildAppURLForWeb(storeFqdn: string, apiKey: string) {
+  const normalizedFQDN = normalizeStoreFqdn(storeFqdn)
   return `https://${normalizedFQDN}/admin/oauth/redirect_from_cli?client_id=${apiKey}`
 }
 
-export async function buildAppURLForMobile(storeFqdn: string, apiKey: string) {
-  const normalizedFQDN = await normalizeStoreFqdn(storeFqdn)
+export function buildAppURLForMobile(storeFqdn: string, apiKey: string) {
+  const normalizedFQDN = normalizeStoreFqdn(storeFqdn)
   const hostUrl = `${normalizedFQDN}/admin/apps/${apiKey}`
   const hostParam = Buffer.from(hostUrl).toString('base64').replace(/[=]/g, '')
   return `https://${hostUrl}?shop=${normalizedFQDN}&host=${hostParam}`

packages/app/src/cli/utilities/extensions/fetch-product-variant.ts

@@ -15,7 +15,7 @@ export async function fetchProductVariant(store: string) {
   const result: FindProductVariantSchema = await adminRequest(FindProductVariantQuery, adminSession)
   const products = result.products.edges
   if (products.length === 0) {
-    const normalizedUrl = `https://${await normalizeStoreFqdn(store)}/admin/products/new`
+    const normalizedUrl = `https://${normalizeStoreFqdn(store)}/admin/products/new`
     const addProductLink = outputContent`${outputToken.link(
       'Add a product',
       normalizedUrl,

packages/cli-kit/src/private/node/session.ts

@@ -200,7 +200,7 @@ export async function ensureAuthenticated(
 
   const previousStoreFqdn = applications.adminApi?.storeFqdn
   if (previousStoreFqdn) {
-    const normalizedStoreName = await normalizeStoreFqdn(previousStoreFqdn)
+    const normalizedStoreName = normalizeStoreFqdn(previousStoreFqdn)
     if (previousStoreFqdn === applications.adminApi?.storeFqdn) {
       applications.adminApi.storeFqdn = normalizedStoreName
     }

packages/cli-kit/src/public/node/api/app-dev.ts

@@ -40,7 +40,7 @@ export async function appDevRequestDoc<TResult, TVariables extends Variables>(
   options: AppDevRequestOptions<TResult, TVariables>,
 ): Promise<TResult> {
   const api = 'App Dev'
-  const normalizedShopFqdn = await normalizeStoreFqdn(options.shopFqdn)
+  const normalizedShopFqdn = normalizeStoreFqdn(options.shopFqdn)
   const fqdn = await appDevFqdn(normalizedShopFqdn)
   const url = `https://${fqdn}/app_dev/unstable/graphql.json`
 

packages/theme/src/cli/utilities/theme-command.ts

@@ -139,8 +139,7 @@ export default abstract class ThemeCommand extends Command {
       })
 
       if (environmentFlags?.store && typeof environmentFlags.store === 'string') {
-        // eslint-disable-next-line no-await-in-loop
-        environmentFlags.store = await normalizeStoreFqdn(environmentFlags.store)
+        environmentFlags.store = normalizeStoreFqdn(environmentFlags.store)
       }
 
       if (environmentFlags?.path && typeof environmentFlags.path === 'string') {