-
Notifications
You must be signed in to change notification settings - Fork 207
Use new copy_files build mode with Flow templates #6309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
50d8352
to
83c55b8
Compare
8c0de77
to
1d8faaf
Compare
83c55b8
to
13812f2
Compare
1d8faaf
to
2452642
Compare
e2cc36d
to
9bbde93
Compare
Coverage report
Show files with reduced coverage 🔻
Test suite run success3243 tests passing in 1359 suites. Report generated by 🧪jest coverage report action from beddeeb |
2452642
to
838606e
Compare
2bed3b6
to
7c0d909
Compare
838606e
to
8f0f766
Compare
7c0d909
to
e9a0adc
Compare
e9a0adc
to
434c6c3
Compare
8f0f766
to
2ed7248
Compare
434c6c3
to
b1979e0
Compare
ca41206
to
f26b4d2
Compare
b1979e0
to
89de6ea
Compare
f26b4d2
to
b6c65ba
Compare
89de6ea
to
46b6836
Compare
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
b6c65ba
to
8f0f766
Compare
46b6836
to
e9a0adc
Compare
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/common/version.d.ts@@ -1 +1 @@
-export declare const CLI_KIT_VERSION = "3.84.1";
\ No newline at end of file
+export declare const CLI_KIT_VERSION = "3.84.0";
\ No newline at end of file
packages/cli-kit/dist/private/node/analytics/error-categorizer.d.ts@@ -1,5 +1,4 @@
export declare enum ErrorCategory {
- Liquid = "LIQUID",
ThemeCheck = "THEME_CHECK",
Network = "NETWORK",
FileSystem = "FILE_SYSTEM",
@@ -7,12 +6,7 @@ export declare enum ErrorCategory {
Validation = "VALIDATION",
Permission = "PERMISSION",
RateLimit = "RATE_LIMIT",
- Json = "JSON",
+ Parsing = "PARSING",
Unknown = "UNKNOWN"
}
-export declare function categorizeError(error: unknown): ErrorCategory;
-/**
- * Formats an error message for analytics tracking, preserving important information
- * based on the error category while keeping it concise and normalized.
- */
-export declare function formatErrorMessage(error: unknown, category: ErrorCategory): string;
\ No newline at end of file
+export declare function categorizeError(error: unknown): ErrorCategory;
\ No newline at end of file
|
8f0f766
to
b6c65ba
Compare
e9a0adc
to
04aae4d
Compare
b6c65ba
to
2e42e1c
Compare
3f326e3
to
577a5ef
Compare
/snapit |
🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm. Test the snapshot by installing your package globally: npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20250916102642 Caution After installing, validate the version by running just |
577a5ef
to
beddeeb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested that works as expected 👌
WHY are these changes introduced?
Simplifies the flow template extension build process by using the existing
copy_files
mode instead of a customflow
mode.WHAT is this pull request doing?
flow
build mode and replaces it with the more genericcopy_files
mode for flow template extensionsoutputFileName
logic to handle all build modes correctlyHow to test your changes?
npm run dev
to verify the extension builds correctlyMeasuring impact
How do we know this change was effective? Please choose one:
Checklist