-
Notifications
You must be signed in to change notification settings - Fork 207
Add new copy_files build mode #6308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
1d8faaf
to
2452642
Compare
Coverage report
Show files with reduced coverage 🔻
Test suite run success3241 tests passing in 1360 suites. Report generated by 🧪jest coverage report action from 2e42e1c |
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
2452642
to
838606e
Compare
e9d37ac
to
f69d123
Compare
f69d123
to
1544b06
Compare
838606e
to
8f0f766
Compare
8f0f766
to
2ed7248
Compare
1544b06
to
1fb62eb
Compare
2ed7248
to
ca41206
Compare
1fb62eb
to
652becc
Compare
ca41206
to
f26b4d2
Compare
652becc
to
bfebf0a
Compare
f26b4d2
to
b6c65ba
Compare
bfebf0a
to
87a7aa1
Compare
b6c65ba
to
8f0f766
Compare
87a7aa1
to
1544b06
Compare
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/common/version.d.ts@@ -1 +1 @@
-export declare const CLI_KIT_VERSION = "3.84.1";
\ No newline at end of file
+export declare const CLI_KIT_VERSION = "3.84.0";
\ No newline at end of file
packages/cli-kit/dist/private/node/analytics/error-categorizer.d.ts@@ -1,5 +1,4 @@
export declare enum ErrorCategory {
- Liquid = "LIQUID",
ThemeCheck = "THEME_CHECK",
Network = "NETWORK",
FileSystem = "FILE_SYSTEM",
@@ -7,12 +6,7 @@ export declare enum ErrorCategory {
Validation = "VALIDATION",
Permission = "PERMISSION",
RateLimit = "RATE_LIMIT",
- Json = "JSON",
+ Parsing = "PARSING",
Unknown = "UNKNOWN"
}
-export declare function categorizeError(error: unknown): ErrorCategory;
-/**
- * Formats an error message for analytics tracking, preserving important information
- * based on the error category while keeping it concise and normalized.
- */
-export declare function formatErrorMessage(error: unknown, category: ErrorCategory): string;
\ No newline at end of file
+export declare function categorizeError(error: unknown): ErrorCategory;
\ No newline at end of file
|
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/common/version.d.ts@@ -1 +1 @@
-export declare const CLI_KIT_VERSION = "3.84.1";
\ No newline at end of file
+export declare const CLI_KIT_VERSION = "3.84.0";
\ No newline at end of file
packages/cli-kit/dist/private/node/analytics/error-categorizer.d.ts@@ -1,5 +1,4 @@
export declare enum ErrorCategory {
- Liquid = "LIQUID",
ThemeCheck = "THEME_CHECK",
Network = "NETWORK",
FileSystem = "FILE_SYSTEM",
@@ -7,12 +6,7 @@ export declare enum ErrorCategory {
Validation = "VALIDATION",
Permission = "PERMISSION",
RateLimit = "RATE_LIMIT",
- Json = "JSON",
+ Parsing = "PARSING",
Unknown = "UNKNOWN"
}
-export declare function categorizeError(error: unknown): ErrorCategory;
-/**
- * Formats an error message for analytics tracking, preserving important information
- * based on the error category while keeping it concise and normalized.
- */
-export declare function formatErrorMessage(error: unknown, category: ErrorCategory): string;
\ No newline at end of file
+export declare function categorizeError(error: unknown): ErrorCategory;
\ No newline at end of file
|
1544b06
to
87a7aa1
Compare
8f0f766
to
b6c65ba
Compare
87a7aa1
to
9cc81cf
Compare
b6c65ba
to
2e42e1c
Compare
WHY are these changes introduced?
To support a new build mode for extensions that allows copying specific files to the output directory based on configurable patterns.
WHAT is this pull request doing?
Adds a new
copy_files
build mode for extensions that:The implementation includes:
BuildConfig
to support the new modecopyFilesForExtension
function to handle the file copying logicHow to test your changes?
shopify app build
Measuring impact
How do we know this change was effective? Please choose one:
Checklist