Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cached files not being updated when one mod registers multiple sources for a file #22

Merged
merged 1 commit into from
Sep 23, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Persona.Merger.Common/Cache/MergedFileCache.cs
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,9 @@ public unsafe bool TryGet(string key, Span<CachedFileSource> sources, [MaybeNull
cachedPath = null;
if (!KeyToFile.TryGetValue(key, out var value))
return false;
// Note: Checking length of 2 collections is not necessary, key uses character invalid
// in modIds, and thus should never have collisions where source count would be different.

if (sources.Length != value.Sources.Length)
return false;

// We write it this way however to elide bounds checks.
fixed (CachedFileSource* currentValueSource = &value.Sources[0])
Expand Down
Loading