Fix cached files not being updated when one mod registers multiple sources for a file #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnimatedSwine37
changed the title
Sewer56
approved these changes
Sep 23, 2023
|
Had a look at the code associated with this, looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the cache assumed that one modId could only have one associated file (which was valid when this was only used for tbl merging).
Now, however, it is possible for one mod to register multiple sources for the same file (for example I do this to add "configurable" parts to files with bf emulator). Because of this there were cases where the cache wouldn't be updated as the sources lengths were not compared. This pr fixes that.