Fix a bug where the "Bypass Duplicate Message Check" setting is ignored (proof of concept) #1136
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Describe the big picture of what you want to change here, to help the maintainers understand why we should accept this pull request. Be sure to link to the issue if it fixes a bug or resolves a feature request.
There is a bug where the setting Chat > Typing > Bypass Duplicate Message Check is ignored when unchecked (see issue #845). Since the bypass inserts an invisible Unicode character (a space and then U+E0000), this can cause 7tv users to be timed out by Twitch moderation bots (AecroBot specifically) that disallow certain classes of Unicode characters.
I was able to confirm in local testing that this fix causes 7tv to not insert the bypass when the setting is unchecked and to insert the bypass when the setting is checked.
I consider this PR to be a proof of concept because I'm not familiar enough with the conventions of Vue development and the 7tv code base.
Types of changes
What types of changes does your code introduce to 7TV?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.