Skip to content

Fix a bug where the "Bypass Duplicate Message Check" setting is ignored (proof of concept) #1136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

akeeton
Copy link

@akeeton akeeton commented Mar 24, 2025

Proposed changes

Describe the big picture of what you want to change here, to help the maintainers understand why we should accept this pull request. Be sure to link to the issue if it fixes a bug or resolves a feature request.

There is a bug where the setting Chat > Typing > Bypass Duplicate Message Check is ignored when unchecked (see issue #845). Since the bypass inserts an invisible Unicode character (a space and then U+E0000), this can cause 7tv users to be timed out by Twitch moderation bots (AecroBot specifically) that disallow certain classes of Unicode characters.

I was able to confirm in local testing that this fix causes 7tv to not insert the bypass when the setting is unchecked and to insert the bypass when the setting is checked.

I consider this PR to be a proof of concept because I'm not familiar enough with the conventions of Vue development and the 7tv code base.

Types of changes

What types of changes does your code introduce to 7TV?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant