Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checkpoint backward compatibility, improve metadata error reporting #47

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

jlamypoirier
Copy link
Collaborator

✨ Description

  • Fix a bug introduced in Checkpoint metadata #28 where older checkpoints were not loaded in the flat format.
  • Re-raise errors in load_metadata as ValueError to prevent them from being hidden when called during validation.
  • Add unknown fields to _to_dict so they are more visible.

🔍 Type of change

Select all that apply:

  • 🐛 Bug fix (non-breaking change that addresses a specific issue)
  • 🚀 New feature (non-breaking change that adds functionality)
  • ⚠️ Breaking change (a change that could affect existing functionality)
  • 📈 Performance improvement/optimization (improves speed, memory usage, or efficiency)
  • 🛠️ Code refactor (non-functional changes that improve code readability, structure, etc.)
  • 📦 Dependency bump (updates dependencies, including Dockerfile or package changes)
  • 📝 Documentation change (updates documentation, including new content or typo fixes)
  • 🔧 Infrastructure/Build change (affects build process, CI/CD, or dependencies)

@jlamypoirier jlamypoirier merged commit 8e930ee into main Nov 18, 2024
2 checks passed
@jlamypoirier jlamypoirier deleted the fix_checkpoint_backward_compatibility branch November 18, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant