Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkpoint metadata #28

Merged
merged 14 commits into from
Oct 31, 2024
Merged

Checkpoint metadata #28

merged 14 commits into from
Oct 31, 2024

Conversation

jlamypoirier
Copy link
Collaborator

@jlamypoirier jlamypoirier commented Oct 25, 2024

✨ Description

  • Add CheckpointMetadata for better checkpoint metadata management.
  • Make checkpoint handlers save the optimizer state by default if the format support it.

🔍 Type of change

Select all that apply:

  • 🐛 Bug fix (non-breaking change that addresses a specific issue)
  • 🚀 New feature (non-breaking change that adds functionality)
  • ⚠️ Breaking change (a change that could affect existing functionality)
  • 📈 Performance improvement/optimization (improves speed, memory usage, or efficiency)
  • 🛠️ Code refactor (non-functional changes that improve code readability, structure, etc.)
  • 📦 Dependency bump (updates dependencies, including Dockerfile or package changes)
  • 📝 Documentation change (updates documentation, including new content or typo fixes)
  • 🔧 Infrastructure/Build change (affects build process, CI/CD, or dependencies)

@tscholak tscholak added this to the 0.2.0 milestone Oct 25, 2024
def get_handler_class(cls):
from fast_llm.engine.checkpoint.state_dict import TrivialCheckpointHandler

return TrivialCheckpointHandler
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice, like this class design a lot!

@jlamypoirier jlamypoirier mentioned this pull request Oct 30, 2024
8 tasks
@jlamypoirier jlamypoirier changed the title More checkpoint improvements Checkpoint metadata Oct 31, 2024
@jlamypoirier jlamypoirier marked this pull request as ready for review October 31, 2024 19:15
@jlamypoirier jlamypoirier merged commit 519e9cb into main Oct 31, 2024
3 of 4 checks passed
@jlamypoirier jlamypoirier deleted the improve_checkpoints branch October 31, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants