-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial setup for search test #2757
Conversation
@JiaHua-Zou can you add a proper description for this, discuss what it does, how to test it, what it's missing (e.g., what's coming next), which issues this fixes or is part of, etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty close, a couple small bits to fix.
931702e
to
1a56ca5
Compare
1a56ca5
to
1791a21
Compare
1791a21
to
2a4528c
Compare
2a4528c
to
841d1f5
Compare
Add the setup path
841d1f5
to
6ed742c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. mdx being broken means master will break if we merge this in which is why I wanna wait to approve it
Issue This PR Addresses
This PR fixes part of the #2621
Type of Change
Description
initial setup files for the search tests.
So far it only has 1 simple test and it test the status if no params are given. More test will be added:
To run it:
pnpm test search
Checklist