Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for search #2621

Closed
AmasiaNalbandian opened this issue Dec 16, 2021 · 0 comments · Fixed by #2757
Closed

Add tests for search #2621

AmasiaNalbandian opened this issue Dec 16, 2021 · 0 comments · Fixed by #2757
Assignees
@RC-Lee @JiaHua-Zou
Labels
type: enhancement New feature or request type: test Creation and development of test
Milestone
2.7 Release

Comments

@AmasiaNalbandian
Copy link
Contributor

What would you like to be added:
Once we complete the searchbar, we need to add tests to the files to ensure they remain correct when making any changes.

Please reference: https://github.com/Seneca-CDOT/telescope/tree/master/src/api/search

Why would you like this to be added:
We need tests for this section of the code, currently there are none.
@AmasiaNalbandian AmasiaNalbandian added type: enhancement New feature or request type: test Creation and development of test labels Dec 16, 2021
@AmasiaNalbandian AmasiaNalbandian mentioned this issue Dec 16, 2021
Merged
8 tasks
@AmasiaNalbandian AmasiaNalbandian added this to the 2.6 Release milestone Jan 25, 2022
@JiaHua-Zou JiaHua-Zou mentioned this issue Jan 27, 2022
Merged
8 tasks
@aserputov aserputov linked a pull request Feb 1, 2022 that will close this issue
initial setup for search test #2757
Merged
8 tasks
@RC-Lee RC-Lee reopened this Feb 3, 2022
@RC-Lee RC-Lee mentioned this issue Feb 3, 2022
Merged
@aserputov aserputov modified the milestones: 2.6 Release, 2.7 Release Feb 3, 2022
@RC-Lee RC-Lee mentioned this issue Feb 11, 2022
Merged
5 tasks
@JiaHua-Zou JiaHua-Zou mentioned this issue Feb 14, 2022
Merged
9 tasks
@RC-Lee RC-Lee closed this as completed Feb 17, 2022
DukeManh pushed a commit to DukeManh/telescope that referenced this issue Mar 7, 2022
@RC-Lee
Merge pull request #52 from rclee91/refactor-elastic
c6cdd75 
[Telescope Seneca-CDOT#2621] Refactoring elastic.js so mock is exported for tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RC-Lee RC-Lee

@JiaHua-Zou JiaHua-Zou

Labels
type: enhancement New feature or request type: test Creation and development of test
Projects
None yet
Milestone
2.7 Release
Development

Successfully merging a pull request may close this issue.

initial setup for search test JiaHua-Zou/telescope
4 participants
@RC-Lee @JiaHua-Zou @aserputov @AmasiaNalbandian