Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed#77: Added Dark theme #1637

Merged
merged 2 commits into from
Feb 3, 2021

Conversation

tonyvugithub
Copy link
Contributor

@tonyvugithub tonyvugithub commented Feb 3, 2021

Issue This PR Addresses

Fixed #77

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

I made some change to ensure we have the same UI as before with Gatsby and added the dark mode option. Since we have not had the header merged yet, I created a temporary toggle button to test the switch mode feature. The button can be found top right when you first load the page.

Light mode
image

Dark mode
image

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@tonyvugithub tonyvugithub self-assigned this Feb 3, 2021
@tonyvugithub tonyvugithub reopened this Feb 3, 2021
@tonyvugithub tonyvugithub changed the title Added Dark theme Fixed#77: Added Dark theme Feb 3, 2021
@tonyvugithub
Copy link
Contributor Author

I am currently working on it.

@HyperTHD HyperTHD added area: css styling Anything related to CSS styling area: front-end area: nextjs Nextjs related issues labels Feb 3, 2021
@HyperTHD HyperTHD marked this pull request as draft February 3, 2021 01:20
Copy link
Contributor

@PedroFonsecaDEV PedroFonsecaDEV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well, but there are some follow-up issues we need to do. At the very least, we need to better integrate this theme switching, and probably serialize the value to localStorage for the user with a hook.

Can you file an issue on this? Approved with that filed.

@tonyvugithub
Copy link
Contributor Author

@humphd : filed the issue #1641

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: css styling Anything related to CSS styling area: front-end area: nextjs Nextjs related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Darkmode js incorporation
4 participants