Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dark mode code colours #2377

Closed
humphd opened this issue Oct 21, 2021 · 5 comments · Fixed by #2769
Closed

Improve dark mode code colours #2377

humphd opened this issue Oct 21, 2021 · 5 comments · Fixed by #2769
Assignees
Labels
area: css styling Anything related to CSS styling type: enhancement New feature or request
Milestone

Comments

@humphd
Copy link
Contributor

humphd commented Oct 21, 2021

Our dark mode isn't great for <code>...</code> (i.e., inline) and <pre><code>...</code></pre> (i.e., block):

Screen Shot 2021-10-21 at 12 30 18 PM

We should probably take a look at how GitHub and other sites render code in dark mode, and see what we can borrow.

@humphd humphd added type: enhancement New feature or request area: css styling Anything related to CSS styling labels Oct 21, 2021
@japneetsingh035
Copy link

Hi @humphd, I would like to work on this. Please let me know if it is not assigned.

@manekenpix
Copy link
Member

@japneetsingh035 all yours!

@japneetsingh035
Copy link

Screen Shot 2021-10-31 at 4 19 49 AM

How about this combination. It is actually similar to GitHub & dev. Please let me know!

@humphd
Copy link
Contributor Author

humphd commented Oct 31, 2021

The red on black isn't great for contrast.

I would look at the existing stylesheets that exist for dark-mode with highlight.js:

japneetsingh035 added a commit to japneetsingh035/telescope that referenced this issue Nov 19, 2021
@japneetsingh035 japneetsingh035 linked a pull request Nov 19, 2021 that will close this issue
8 tasks
@japneetsingh035 japneetsingh035 removed their assignment Dec 10, 2021
@cindyorangis
Copy link
Contributor

Wow, someone is taking on this age-old issue? Originally #77 We had this working at some point on Telescope. It was added and removed by the Telescope 2.0 group. Maybe you can hunt down someone from that cohort who knows more... #1637 , as you can see, it was using the Material UI theming thing. We once had a button that we could toggle to switch to dark mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: css styling Anything related to CSS styling type: enhancement New feature or request
Projects
None yet
9 participants