Skip to content

Conversation

@krabina
Copy link
Contributor

@krabina krabina commented Mar 29, 2025

first day of week issue
#138

first day of week issue
#138
@krabina
Copy link
Contributor Author

krabina commented Mar 29, 2025

@paladox @gesinn-it-gea any idea why this is failing?

Fix phpcs issue
@codecov
Copy link

codecov bot commented Mar 29, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 45.55%. Comparing base (48c9a17) to head (6affed1).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
formats/calendar/SRF_Calendar.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #929   +/-   ##
=========================================
  Coverage     45.55%   45.55%           
  Complexity     2318     2318           
=========================================
  Files            80       80           
  Lines          9044     9044           
=========================================
  Hits           4120     4120           
  Misses         4924     4924           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@paladox
Copy link
Contributor

paladox commented Mar 29, 2025

It's just codecov failing because a line you touched isn't covered by tests.

@JeroenDeDauw
Copy link
Member

It's just codecov failing because a line you touched isn't covered by tests.

That are some bad codecov settings then

@JeroenDeDauw JeroenDeDauw merged commit 7026407 into master Mar 29, 2025
6 of 7 checks passed
@JeroenDeDauw JeroenDeDauw deleted the krabina-patch-1 branch March 29, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants