Calendar format: Parameter `$srfgFirstDayOfWeek` broken?

[kghbln]

Though I am setting $srfgFirstDayOfWeek = 'monday'; I am getting a warning and it is obviously being ignored as the example shows. Perhaps this can be turned from a configuration parameter to a result parameter as it is done for the 'eventcalendar' format.

Code starts at this spot.

[kghbln]

@s7eph4n If I am not mistaken you originally authored this configuration parameter. So you might be able to have a look. Thanks and cheers

[kghbln]

I will try $srfgFirstDayOfWeek = 'Monday'; instead of $srfgFirstDayOfWeek = 'monday';. It seems that weekday need to have a capital letter in any case. I will reopen in case this does not help.

[s7eph4n]

Sorry, I totally missed this.

$srfgFirstDayOfWeek is set in SRF_Calendar.php.

It can be either a number (1 = Sunday, 7 = Saturday), or the name of the day in the wiki language. Since in English daynames are capitalized, "Monday" should work, whereas "monday" probably won't.

[kghbln]

"Monday" should work, whereas "monday" probably won't.

Yeah, thanks for confirming. Just reconfigured and it is working. Also fixed the docu.

[kghbln]

@s7eph4n We really need a stable solution here. After upgrading to MW 1.31 we start to get Warning: Bad value for $srfgFirstDayOfWeek "(Monday") on sandbox Switching to "lundi" or "Lundi" does not help either.

I would really appreciate a solid solution e.g. specify numbers 1 to 7 instead of names.

[kghbln]

After upgrading to MW 1.31

Perhaps it is also resulting from a PHP upgrade which happened since I first reported this.

[kghbln]

Do not understand me wrong, but this setting really goes me gewaltig auf den Sack - for years now. I now suspect that this is dependent on the locale of the server. I really have not clue when PHP expects what. Now I set this to Monday and the error goes away. Please change this to numbers, please, if possible.

[kghbln]

No it does not fix to set to "Monday". Now I am being spammed by cron about this problem. I have no clue, thus I commented out this configuration setting.

[thomasramm]

i run into the same problem, and find the solution.
actually the extension try to translate the weekdays into the user language. But this depends on Individual User Setting! Not on Server Setting.
If i set the value in LocalSettings.php to 'Montag' this works only for my Users with Language=German,
If i set the value in LocalSettings.php to 'Monday' this works only for my Users with Language=English.

Reason
On SRF_Calender.php the array "$weekDayNames" is filled with weekdays in UserSetting-Language.
i add print_r($weekDayNames); to the code to have a look into this array.
if i set my user language to German i get
Array ( [1] => Sonntag [2] => Montag [3] => Dienstag [4] => Mittwoch [5] => Donnerstag [6] => Freitag [7] => Samstag )
if i set my user language to English i get
Array ( [1] => Sunday [2] => Monday [3] => Tuesday [4] => Wednesday [5] => Thursday [6] => Friday [7] => Saturday )

But then it try to find the correct value based on the value you set in LocalSettings.php
So the Solution is to translate $srfgFirstDayOfWeek also to the UserLanguage and use the english value in LocalSettings as base to find the correct translation.

**Solution''
The Code needs to change from $firstDayOfWeek = array_search($srfgFirstDayOfWeek, $weekDayNames );
to (Line ~393) $firstDayOfWeek = array_search( wfMessage($srfgFirstDayOfWeek)->text(), $weekDayNames );

And in LocalSettings.php you have to use the english value, e.g.: $srfgFirstDayOfWeek = 'Monday';

This Works on my Wiki

Also the documentation has to be updated if you adapt this solution. On https://www.semantic-mediawiki.org/wiki/Help:Ergebnisformat_calendar. and all the translations.

PS: my config: MW 1.40.0, SMW 4.1.2, SRF 4.0.2.