Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bazel + ci]: Stop being selective about which parts of the tree to test #14373

Merged
merged 4 commits into from
Aug 12, 2024

Conversation

shs96c
Copy link
Member

@shs96c shs96c commented Aug 10, 2024

User description

Now that we've got every part of the tree building with Bazel, we can stop being so selective about what we test.


PR Type

enhancement, configuration changes


Description

  • Removed selective testing of specific directories in the CI build script.
  • Enabled testing for the entire codebase by modifying the Bazel test command.
  • Simplified the CI configuration to ensure all parts of the tree are tested.

Changes walkthrough 📝

Relevant files
Enhancement
ci-build.sh
Enable comprehensive testing across the entire codebase in CI

scripts/github-actions/ci-build.sh

  • Removed selective testing of specific directories.
  • Enabled testing for the entire codebase.
  • Simplified the Bazel test command.
  • +1/-7     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    Copy link
    Contributor

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Key issues to review

    Simplification Check
    Ensure that the simplification of the Bazel test command (//... -- $(cat .skipped-tests | tr '\n' ' ')) does not unintentionally include previously excluded directories that should not be tested due to specific reasons (e.g., breaking builds, non-testable code).

    Copy link
    Contributor

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @shs96c shs96c merged commit 596070d into SeleniumHQ:trunk Aug 12, 2024
    9 checks passed
    @shs96c shs96c deleted the selective-ci branch August 12, 2024 09:15
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant