Skip to content

Commit

Permalink
[bazel + ci]: Stop being selective about which parts of the tree to t…
Browse files Browse the repository at this point in the history
…est (#14373)

We no longer need to do this now that the entire project is built with Bazel.
  • Loading branch information
shs96c authored Aug 12, 2024
1 parent 3bad4c7 commit 596070d
Show file tree
Hide file tree
Showing 4 changed files with 31 additions and 27 deletions.
2 changes: 2 additions & 0 deletions .skipped-tests
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
-//javascript/atoms:test-chrome
-//javascript/atoms:test-edge
-//javascript/atoms:test-firefox-beta
-//javascript/chrome-driver/...
-//javascript/node/selenium-webdriver:test-bidi-network-test.js-chrome
-//javascript/node/selenium-webdriver:test-builder-test.js-chrome
-//javascript/node/selenium-webdriver:test-builder-test.js-firefox
Expand Down Expand Up @@ -54,3 +55,4 @@
-//rb/spec/integration/selenium/webdriver:element-chrome
-//rb/spec/integration/selenium/webdriver:element-chrome-bidi
-//rb/spec/integration/selenium/webdriver:element-chrome-remote
-//rust/tests/...
22 changes: 2 additions & 20 deletions rust/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
load("@crates//:defs.bzl", "all_crate_deps")
load("//rust:defs.bzl", "rust_binary", "rust_library", "rust_test", "rust_test_suite", "rustfmt_config")
load("//rust:defs.bzl", "rust_binary", "rust_library", "rust_test", "rustfmt_config")

rustfmt_config(
name = "enable-rustfmt",
Expand Down Expand Up @@ -92,6 +92,7 @@ rust_library(
exclude = ["main.rs"],
),
edition = "2021",
visibility = ["//rust:__subpackages__"],
deps = all_crate_deps(normal = True),
)

Expand All @@ -117,22 +118,3 @@ rust_test(
edition = "2021",
tags = ["no-sandbox"],
)

rust_test_suite(
name = "integration",
size = "small",
srcs = glob(["tests/**/*_tests.rs"]),
data = [
"tests/common.rs",
":selenium-manager",
],
edition = "2021",
tags = [
"no-sandbox",
"requires-network",
],
deps = [":selenium_manager"] + all_crate_deps(
normal = True,
normal_dev = True,
),
)
26 changes: 26 additions & 0 deletions rust/tests/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
load("@crates//:defs.bzl", "all_crate_deps")
load("//rust:defs.bzl", "rust_test_suite", "rustfmt_config")

rustfmt_config(
name = "enable-rustfmt",
)

rust_test_suite(
name = "integration",
size = "small",
srcs = glob(["**/*_tests.rs"]),
data = [
"common.rs",
"//rust:selenium-manager",
],
edition = "2021",
tags = [
"no-sandbox",
"requires-network",
],
deps = ["//rust:selenium_manager"] + all_crate_deps(
package_name = "rust",
normal = True,
normal_dev = True,
),
)
8 changes: 1 addition & 7 deletions scripts/github-actions/ci-build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,7 @@ set -x
bazel test --config=remote-ci --build_tests_only \
--test_tag_filters=-exclusive-if-local,-skip-remote \
--keep_going --flaky_test_attempts=2 \
//dotnet/... \
//java/... \
//javascript/atoms/... \
//javascript/node/selenium-webdriver/... \
//javascript/webdriver/... \
//py/... \
//rb/spec/... -- $(cat .skipped-tests | tr '\n' ' ')
//... -- $(cat .skipped-tests | tr '\n' ' ')

# Build the packages we want to ship to users
bazel build --config=remote-ci \
Expand Down

0 comments on commit 596070d

Please sign in to comment.