Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tensorflow upperbound macos #1901

Merged
merged 5 commits into from
Sep 9, 2024
Merged

Fix tensorflow upperbound macos #1901

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4755b52
Limited transformers version for macos
RobertSamoilescu Sep 9, 2024
9da30ce
Temporary change to test hf-runtime
RobertSamoilescu Sep 9, 2024
ed1b085
Included comment for tensorflow macos upperbound
RobertSamoilescu Sep 9, 2024
2dfaff6
Reverted workflow
RobertSamoilescu Sep 9, 2024
475f88e
Update runtimes/huggingface/pyproject.toml
RobertSamoilescu Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 78 additions & 1 deletion runtimes/huggingface/poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion runtimes/huggingface/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,13 @@ torch = [
{markers = "sys_platform == 'darwin' and platform_machine == 'x86_64'", version = "<2.3.0"},
{markers = "sys_platform != 'darwin' or platform_machine != 'x86_64'", version = "<2.4.0"}
]
# tensorflow 2.17.0 not compiled for MacOS
RobertSamoilescu marked this conversation as resolved.
Show resolved Hide resolved
# see: https://www.tensorflow.org/install/pip#package_location
tensorflow = [
{markers = "sys_platform == 'darwin' and platform_machine == 'x86_64'", version = ">=2.12,<2.17"},
{markers = "sys_platform != 'darwin' or platform_machine != 'x86_64'", version = ">=2.12,<2.18"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is probably fine, although I wondered a bit if we should be explicitly about what we include (as opposed to exclude).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since 2.17.0 is the latest version, I think it is ok. If future version will support MacOS, then we can be more explicit about the version we want to include/exclude.

]
transformers = ">=4.30,<5.0"
tensorflow = ">=2.12,<2.18"

[build-system]
requires = ["poetry-core"]
Expand Down