Fix tensorflow upperbound macos #1901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakoush
approved these changes
Sep 9, 2024
| # see: https://www.tensorflow.org/install/pip#package_location | ||
| tensorflow = [ | ||
| {markers = "sys_platform == 'darwin' and platform_machine == 'x86_64'", version = ">=2.12,<2.17"}, | ||
| {markers = "sys_platform != 'darwin' or platform_machine != 'x86_64'", version = ">=2.12,<2.18"} |
There was a problem hiding this comment.
It is probably fine, although I wondered a bit if we should be explicitly about what we include (as opposed to exclude).
There was a problem hiding this comment.
Since 2.17.0 is the latest version, I think it is ok. If future version will support MacOS, then we can be more explicit about the version we want to include/exclude.
Co-authored-by: Sherif Akoush <sherif.akoush@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limited
tensorflowupperbound to2.17for macos.It seems that
2.17is not compiled formacos(see package location here)