Skip to content

v5.114.0
Compare
Choose a tag to compare
@github-actions github-actions released this 13 Oct 09:51
· 133 commits to master since this release
v5.114.0
3b0b102
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Learn about vigilant mode.

5.114.0 (2024-10-13)

Features

  • (sc-25088) 1st a11y pass of tab interface. Allow navigation by keyboard (b0d1319)
  • change behavior of language toggle to reflect latest decisions [sc-24443] (8f43f07)
  • close language select panel on any click not inside it. (e1f7c29)
  • First pass at lang selector for topics page (c369a9e)
  • new topic page tabs: at bottom of the scrolled view, add 80px of vertical padding before the footer (b97cbfd)
  • new topic page tabs: better way of making filter disappear when key-sources is on (275ade5)
  • new topic page tabs: center topic image in mobile web (79f8c08)
  • new topic page tabs: expand margin between filter and popover (b1b0827)
  • new topic page tabs: filter out ref-links that lack description in the current interface language (f3f1e05)
  • new topic page tabs: fix justification of icons Hebrew mobile web (970df3e)
  • new topic page tabs: fix justification of icons in Hebrew (fc81377)
  • new topic page tabs: justify icons in mobile web (1658fb9)
  • new topic page tabs: make tab titles smaller in mobile web (42a8a3d)
  • new topic page: apply the 'hide Englishless sources' feat on allSources tab (bcc0d6c)
  • new topic page: hide Englishless sources when in 'translation' mode (7219f35)
  • new topic page: hide sources with missing hebrew (cd3696b)
  • new topic page: laying the ground works for new admin tab (da968a3)
  • polish for language selector on title page. (9e482f6)
  • redirect sheets only topics pages to search page [sc-24442] (f2a3dbd)
  • topics: add analytics data to topics page (b7d7b12)
  • topics: add AnalyticsEventTracker to base.html (d854f27)
  • topics: add bulk analytics data to ReaderPanel (121a7f4)
  • topics: add from field to all details related analytics (e1cb476)
  • topics: add new function topicTocCategories which returns all categories for a topic (41061f8)
  • topics: add toggle event (3b53f88)
  • topics: add toggle event to base.html (5d3649f)
  • topics: all analytics for toggle event (a5b6b9c)
  • topics: allow adding bulk analytics data through data attribute (7c70f7f)
  • topics: allow listening for multiple analytics events on one element (48cacb9)
  • topics: Allow only a single featured topic open at a time (87e867b)
  • topics: allow triggering analytics events through data attributes (eda138a)
  • topics: Create pathway for key sources (33ad7a8)
  • topics: Default source language: EN only for EN interface, HE only for HE interface (46d6b66)
  • topics: fully working analyticsEventTracker.js (c9c5cbe)
  • topics: handle toggle events which don't bubble. (aa69199)
  • topics: Hebrew polish pass (9d5a4a4)
  • topics: implement scrollIntoView event for analyticsEventTracker.js (a10cad5)
  • topics: Open first accordian on page load (a6d63fe)
  • topics: Redesign stories on topics page. (cb69bdf)
  • topics: Replace Sheets tab w/ link to seatch results (85c65b2)
  • topics: Special casing of Parsha and Author pages [sc-24533] (8f72dce)
  • topics: track scrollIntoView event for source package (db02e46)
  • topics: undo changes that added analytics event tracking into ReaderApp. (eae2e8d)
  • topics: use gtag (731564c)
  • Undo logic on source packages on topics pages [sc-25426] (d567ede)

Bug Fixes

  • Design Polish [sc-25705] (5bf2970)
  • More polish for language selector on topic page (e430ac8)
  • new topic page tabs: Mobile web both languages: the funnel icon is higher than the "A" (or aleph) icon. They should be the same vertical alignment as they are on desktop. Hebrew: the Aleph icon should be the same height as the funnel icon (f9006d6)
  • new topic page tabs: Mobile web: the grey line below the Key sources or All sources tabs should be connected to the thinner grey horizontal line below it (409bbc5)
  • new topic page: *HACK to make English text of sources in topic pages lrt (95ddee5)
  • new topic page: enable display of English texts in topic pages while interfaceLanguage is Hebrew (06e7295)
  • new topic page: increase padding to close gap seen on iphone (cda39f4)
  • new topic page: make language icon menu z-index cover all other elements, i.e, not transparent (b0afd4d)
  • new topic page: make underline thicker in mobile web (696a37f)
  • new topic page: move lang icon menu to the right for hebrew mobile interface (a33cdf4)
  • new topicPage design: try using -webkit to remove chevron from ios (21a51d1)
  • topic page: change default tab to 'key-sources' (d3e707a)
  • topic page: make editor cover filter icon (e2875b6)
  • topic page: make mouse pointer on pencil button (66cb246)
  • topic page: rename admin tab (ff4fb19)
  • topic page: rename admin tab key to admin (5cfab65)
  • topic page: return to current tab after reorder sources (89d54e6)
  • topic page: source to appear under key sources iff source has title or prompt (3a34089)
  • topic page: when saving source, after refresh return to the tab you were at (1525d3f)
  • topics: Adds CSS hack to get spacing correct on featured content details that include CategoryHeader components. (5b5d11f)
  • topics: dont fail if passage doesn't have valid ref (ad5cc19)
  • topics: Ensure opened element is in view (574c3fd)
  • topics: fix learn more and feedback links (ca3adc4)
  • topics: fix panel number and panel name (b763b34)
  • topics: Fix typo (015a2be)
  • topics: remove sheets from topics data (19b2cc8)
  • topics: remove typo (053f339)
  • topics: Show featured content in he interface only when Hebrew descriptions exist (e6b65b5)
  • topics: track click event on related topic link (e2e6544)
  • topics: track toggle event on source package (bf4233b)
Assets 2
Loading