feat(topics): Create pathway for key sources

Sefaria · Feb 9, 2024 · 33ad7a8 · 33ad7a8
1 parent 8f72dce
commit 33ad7a8
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 11 deletions.
diff --git a/static/js/TopicPage.jsx b/static/js/TopicPage.jsx
@@ -367,6 +367,14 @@ const useTabDisplayData = (translationLanguagePreference) => {
       sortFunc: refSort,
       renderWrapper: refRenderWrapper,
     },
+    {
+      key: 'key-sources',
+      fetcher: fetchBulkText.bind(null, translationLanguagePreference),
+      sortOptions: ['Relevance', 'Chronological'],
+      filterFunc: refFilter,
+      sortFunc: refSort,
+      renderWrapper: refRenderWrapper,
+    },
     {
       key: 'sources',
       fetcher: fetchBulkText.bind(null, translationLanguagePreference),
@@ -538,12 +546,12 @@ const TopicPage = ({
                           currTabName={tab}
                           setTab={setTab}
                           tabs={displayTabs}
-                          renderTab={t => {console.log(t); return (
+                          renderTab={t => (
                             <div className={classNames({tab: 1, noselect: 1, filter: t.justifyright, open: t.justifyright && showFilterHeader})}>
                               <InterfaceText text={t.title} />
                               { t.icon ? <img src={t.icon} alt={`${t.title.en} icon`} /> : null }
                             </div>
-                          )}}
+                          )}
                           containerClasses={"largeTabs"}
                           onClickArray={{[onClickFilterIndex]: ()=>setShowFilterHeader(!showFilterHeader)}}
                         >

diff --git a/static/js/sefaria/sefaria.js b/static/js/sefaria/sefaria.js
@@ -317,24 +317,24 @@ Sefaria = extend(Sefaria, {
     }
   },
     /**
-     * Helps the BookPage toc translate the given integer to the correctly formatted display string for the section given the varying address types. 
+     * Helps the BookPage toc translate the given integer to the correctly formatted display string for the section given the varying address types.
      * @param {string} addressType - The address type of the schema being requested
      * @param {number} i - The numeric section string from the database
      * @param {number} offset - If needed, an offest to allow section addresses that do not start counting with 0
-     * @returns {[string,string]} Section string in both languages. 
-     */  
+     * @returns {[string,string]} Section string in both languages.
+     */
   getSectionStringByAddressType: function(addressType, i, offset=0) {
     let section = i + offset;
     let enSection, heSection;
     if (addressType === 'Talmud') {
       enSection = Sefaria.hebrew.intToDaf(section);
       heSection = Sefaria.hebrew.encodeHebrewDaf(enSection);
     } else if (addressType === "Year") {
-      enSection = section + 1241;  
+      enSection = section + 1241;
       heSection = Sefaria.hebrew.encodeHebrewNumeral(section+1);
       heSection = heSection.slice(0,-1) + '"' + heSection.slice(-1);
     } else if (addressType === "Folio") {
-      enSection = Sefaria.hebrew.intToFolio(section);  
+      enSection = Sefaria.hebrew.intToFolio(section);
       heSection = Sefaria.hebrew.encodeHebrewFolio(enSection);
     } else {
       enSection = section + 1;
@@ -2520,22 +2520,23 @@ _media: {},
       for (let refObj of linkTypeObj.refs) {
         let tabKey = linkTypeSlug;
         if (tabKey === 'about') {
-          tabKey = refObj.is_sheet ? 'sheets' : 'sources';
+          tabKey = refObj.descriptions ? 'key-sources' : 'sources';
         }
         if (!tabs[tabKey]) {
           let { title } = linkTypeObj;
-          if (tabKey === 'sheets') {
-            title = {en: 'Sheets', he: Sefaria._('Sheets')};
+          if (tabKey === 'key-sources') {
+            title = {en: 'Key Sources', he: Sefaria.translation('hebrew', 'Key Sources')};
           }
           if (tabKey === 'sources') {
-            title = {en: 'Sources', he: Sefaria._('Sources')};
+            title = {en: 'Sources', he: Sefaria.translation('hebrew', 'Sources')};
           }
           tabs[tabKey] = {
             refMap: {},
             title,
             shouldDisplay: linkTypeObj.shouldDisplay,
           };
         }
+        console.log(refObj)
         const ref = refObj.is_sheet ? parseInt(refObj.ref.replace('Sheet ', '')) : refObj.ref;
         if (refObj.order) {
             refObj.order = {...refObj.order, availableLangs: refObj?.order?.availableLangs || [],
@@ -2550,6 +2551,11 @@ _media: {},
       tabObj.refs = Object.values(tabObj.refMap);
       delete tabObj.refMap;
     }
+
+    if (tabs["key-sources"]) {
+      tabs["sources"]["title"] = {en: 'All Sources', he: Sefaria.translation('hebrew', 'All Sources')};
+    }
+
     data.tabs = tabs;
     return data;
   },

diff --git a/static/js/sefaria/strings.js b/static/js/sefaria/strings.js
@@ -248,6 +248,8 @@ const Strings = {
     "Merged from": "נוצר ממיזוג",
     "Source" : "מקור",
     "Sources": "מקורות",
+    "Key Sources": "מקורות מרכזיים",
+    "All Sources": "כל המקורות",
     "Digitization" : "דיגיטציה",
     "License" : "רשיון",
     "Revision History" : "היסטורית עריכה",