Update for ember 4.12 #3
Conversation
Gaurav0
force-pushed
the
update_for_ember_4.12
branch
2 times, most recently
from
c4e6c44 to
4eda44b
Compare
do not test ember 4.12 in CI due to bug in @ember/string deprecation
…mption error in Ember canary (ember-bootstrap#2027) * Refactor bs-alert to remove @localcopy The `@localCopy` decorate caused issues on Ember canary builds. By refactoring this component to use pure Ember reactivity we can get rid of the decorator. * Allow re-enabling of alert using property after hiding it by clicking
Gaurav0
force-pushed
the
update_for_ember_4.12
branch
from
982d5d4 to
91b75b4
Compare
| @@ -342,19 +342,6 @@ module('Integration | Component | bs-tooltip', function (hooks) { | |||
| assert.ok(isVisible(this.element.querySelector('.tooltip')), '200ms: tooltip is faded in'); | |||
| }); | |||
|
|
|||
| test('should not show tooltip if leave event occurs before delay expires', async function (assert) { | |||
There was a problem hiding this comment.
Is this test removal somehow related to the commit intention: manually fix remaining eslint errors?
There was a problem hiding this comment.
Yes. This test was exactly repeated here: https://github.com/SeeClickFix/ember-bootstrap/pull/3/files/0c97a6e6909147ccc680d581a026ea0333d70c94..1926986afb9c1ae504e67f7762f85f2380c1f06c#diff-76efafe46ae5f3d5dd46e811d7dd836cd5250c59038f87eb3d86153c0c2801c6L373-L383 causing an error in eslint "duplicate test name"
| @@ -5,7 +5,7 @@ | |||
| {{else}} | |||
| {{#if @submitTitle}} | |||
| <Button @onClick={{@onClose}}>{{bs-default @closeTitle "Ok"}}</Button> | |||
| <Button @type={{bs-default @submitButtonType "primary"}} onClick={{@onSubmit}} disabled={{bs-default @submitDisabled false}}>{{@submitTitle}}</Button> | |||
| <Button @type={{bs-default @submitButtonType "primary"}} @buttonType="submit" onSubmit={{@onSubmit}} disabled={{bs-default @submitDisabled false}}>{{@submitTitle}}</Button> | |||
| @@ -68,7 +68,7 @@ | |||
| "ember-concurrency": "^2.1.2", | |||
| "ember-decorators": "^6.1.0", | |||
| "ember-element-helper": "^0.6.0", | |||
| "ember-focus-trap": "^0.8.0", | |||
| "ember-focus-trap": "^1.0.0", | |||
There was a problem hiding this comment.
question: Any breaking changes moving to 1.0?
@Joeu @Gaurav0 Can you guys review https://github.com/josemarluedke/ember-focus-trap/releases (WRT to any accessbility changes we have done recently with focus trap).
| @@ -2,6 +2,7 @@ | |||
| class="{{unless this.hidden "alert"}} {{if this.fade "fade"}} {{if this.dismissible "alert-dismissible"}} {{bs-type-class "alert" @type}} {{if this.showAlert (if (macroCondition (macroGetOwnConfig "isNotBS3")) "show" "in")}}" | |||
| ...attributes | |||
| {{did-update this.showOrHide this._visible}} | |||
| {{did-update this.updateVisibility @visible}} | |||
| @@ -241,7 +241,7 @@ module('Integration | Component | bs-form', function (hooks) { | |||
| assert.dom(`.${formFeedbackClass()}`).hasText('There is an error'); | |||
| }); | |||
|
|
|||
| test('it does not catch errors thrown by onSubmit action', async function (assert) { | |||
| skip('it does not catch errors thrown by onSubmit action', async function (assert) { | |||
There was a problem hiding this comment.
question: what is this test testing? Should we try to fix it? Should we remove it?
.github/workflows/ci.yml
Outdated
| browser: Chrome | ||
| bootstrap: 5 | ||
| allow-failure: true | ||
| # - scenario: ember-release |
There was a problem hiding this comment.
suggestion: remove comments and/or the changes in the commit that introduces failing build combinations
This updates ember-bootstrap for use in Ember 4.12. It also passes internal tests in Ember 5.4 and Ember 5.8.
It fails tests in Ember 4.12 due to bug in
@ember/stringdeprecation: emberjs/ember.js#20377