Update for ember 4.12 #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gaurav0
force-pushed
the
update_for_ember_4.12
branch
2 times, most recently
from
074f774 to
3f6a60b
Compare
Gaurav0
force-pushed
the
update_for_ember_4.12
branch
from
3f6a60b to
e7b5b28
Compare
Gaurav0
force-pushed
the
update_for_ember_4.12
branch
from
e7b5b28 to
c7385c1
Compare
Gaurav0
force-pushed
the
update_for_ember_4.12
branch
2 times, most recently
from
268afff to
faf17fd
Compare
Gaurav0
force-pushed
the
update_for_ember_4.12
branch
from
faf17fd to
afbae73
Compare
Gaurav0
force-pushed
the
update_for_ember_4.12
branch
from
ec6310f to
e74ac09
Compare
do not test ember 4.12 in CI due to bug in @ember/string deprecation
Gaurav0
force-pushed
the
update_for_ember_4.12
branch
from
a3f9d99 to
4f2213e
Compare
…mption error in Ember canary (ember-bootstrap#2027) * Refactor bs-alert to remove @localcopy The `@localCopy` decorate caused issues on Ember canary builds. By refactoring this component to use pure Ember reactivity we can get rid of the decorator. * Allow re-enabling of alert using property after hiding it by clicking
Gaurav0
force-pushed
the
update_for_ember_4.12
branch
from
bde6cef to
fe95c91
Compare
Gaurav0
force-pushed
the
update_for_ember_4.12
branch
from
e220f31 to
83affa3
Compare
|
@ssawyer1024 @Joeu Can we enable tests for this project so @Gaurav0 doesn't have to maintain a parallel branch on his personal account? Also, need some help reviewing this, it's a preqreq/blocker to https://github.com/SeeClickFix/partners/pull/3133 |
|
Closing in favor of #3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See test results here: Gaurav0#2
This updates ember-bootstrap for use in Ember 4.12. It also passes internal tests in Ember 5.4 and Ember 5.8.
It fails tests in Ember 4.12 due to bug in
@ember/stringdeprecation: emberjs/ember.js#20377