Skip to content

Commit

Permalink
markdownlint-cli2, pin bundler, drop node 16, add node 21 (#8)
Browse files Browse the repository at this point in the history
* Add markdownlint-cli2

* Pin bundler version

* Update Dockerfile

* Update Dockerfile

* Update README.md

* Update build.yml
  • Loading branch information
SeanKilleen authored Jan 30, 2024
1 parent 6126c3e commit 407546d
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
strategy:
matrix:
VERSIONS: [ {ruby: 2.7.3, ghpages: 226}, {ruby: 2.7.4, ghpages: 228}]
NODE_MAJOR_VERSION: [16,18,20]
NODE_MAJOR_VERSION: [18,20,21]
runs-on: ubuntu-latest
env:
RUBY_VERSION: ${{ matrix.VERSIONS.ruby }}
Expand Down
8 changes: 6 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,11 @@ ARG BUILD_DATE
ARG VCS_REF
ARG GH_PAGES_VERSION=228
ARG NODE_MAJOR_VERSION=18
# Bundler 2.4.x is the last to support ruby < 3.0.0
ARG BUNDLER_VERSION=2.4.22

RUN echo "RUBY_VERSION=${RUBY_VERSION}"
RUN echo "BUNDLER_VERSION=${BUNDLER_VERSION}"
RUN echo "BUILD_DATE=${BUILD_DATE}"
RUN echo "VCS_REF=${VCS_REF}"
RUN echo "GH_PAGES_VERSION=${GH_PAGES_VERSION}"
Expand Down Expand Up @@ -48,7 +51,7 @@ RUN apt-get -y install \
tzdata \
dos2unix

RUN gem install bundler
RUN gem install bundler -v ${BUNDLER_VERSION}

#################################################################
# Installing node #
Expand All @@ -66,5 +69,6 @@ RUN curl -sL https://deb.nodesource.com/setup_${NODE_MAJOR_VERSION}.x | bash -\
RUN node -v
RUN npm -v
RUN npm install -g cspell markdownlint-cli
RUN npm install -g markdownlint-cli2

EXPOSE 4000
EXPOSE 4000
5 changes: 4 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,10 @@ We try to keep it up to date with [the GitHub Pages dependencies](https://pages.
* Ruby, at the specified version (currently publish with 2.7.3 to match GitHub pages preferred version)
* Git, tzdata updates, and the latest `bundler` gem at the time of build
* Node at the specified major version (currently 16.x)
* the `cSpell` and `markdownlint-cli` npm packages globally installed
* the following npm packages globally installed:
* `cSpell`
* `markdownlint-cli`
* `markdownlint-cli2`
* Port 4000 exposed, as this is what Jekyll publishes on.

## Get Involved
Expand Down

0 comments on commit 407546d

Please sign in to comment.