Skip to content

fix(vintage-miner): use client.multiplier instead of missing evidence profile key (#7766)#7785

Merged
Scottcjn merged 2 commits into
Scottcjn:mainfrom
lequangsang01:fix/7766-vintage-miner-keyerror
Jul 1, 2026
Merged

fix(vintage-miner): use client.multiplier instead of missing evidence profile key (#7766)#7785
Scottcjn merged 2 commits into
Scottcjn:mainfrom
lequangsang01:fix/7766-vintage-miner-keyerror

Conversation

@lequangsang01

Copy link
Copy Markdown
Contributor

Closes #7766

RTC wallet: RTCfe13452d122263caf633ab1876bd9631133b68b1

Changes

  • Replaced evidence["profile"]["multiplier"] lookup with client.multiplier
  • Fixed KeyError crash that occurred after successful attestation
  • Client already has the multiplier value from its initialization

Testing

  • Verified client.multiplier attribute exists and is populated
  • No automated tests needed for this one-line fix

@github-actions github-actions Bot added BCOS-L1 Beacon Certified Open Source tier BCOS-L1 (required for non-doc PRs) size/XS PR: 1-10 lines labels Jun 30, 2026

@FakerHideInBush FakerHideInBush left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR makes the exact same single-line change as the already-open PRs #7767 and #7768 — all three modify vintage_miner/vintage_miner_client.py line 433 identically:

-            print(f"Multiplier: {evidence['profile']['multiplier']}x")
+            print(f"Multiplier: {client.multiplier}x")

With three PRs making the same change to the same line, only one can merge cleanly — the other two will either conflict or become no-ops. PR #7768 was flagged for duplication with #7767 in an earlier review; now #7785 creates a third copy.

Recommendation: Close this PR and PR #7768 in favor of PR #7767 (the earliest-opened version), or close all three and submit one consolidated PR that:

  1. Fixes the evidence['profile']['multiplier']client.multiplier display bug
  2. References the issue it closes (e.g. Closes #7766)
  3. Checks whether client.multiplier is available at the call site in all code paths that invoke attest()

@lequangsang01
lequangsang01 force-pushed the fix/7766-vintage-miner-keyerror branch from 010ce68 to fa37870 Compare June 30, 2026 05:03
@github-actions github-actions Bot added BCOS-L2 Beacon Certified Open Source tier BCOS-L2 (required for non-doc PRs) node Node server related api API endpoint related tests Test suite changes size/S PR: 11-50 lines and removed BCOS-L2 Beacon Certified Open Source tier BCOS-L2 (required for non-doc PRs) size/XS PR: 1-10 lines node Node server related api API endpoint related tests Test suite changes labels Jun 30, 2026

@jaxint jaxint left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

This PR fixes vintage miner multiplier lookup.

Changes:

  • Uses client.multiplier instead of missing evidence profile key
  • Fixes KeyError for vintage miners without evidence profile

Quality:

  • Simple, targeted fix
  • Follows existing patterns

APPROVED

@Scottcjn
Scottcjn merged commit b4ed432 into Scottcjn:main Jul 1, 2026
11 checks passed
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

RTC Reward

This merged PR earned 5 RTC — sent to RTCfe13452d122263caf633ab1876bd9631133b68b1.

RustChain Bounty Program

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BCOS-L1 Beacon Certified Open Source tier BCOS-L1 (required for non-doc PRs) size/S PR: 11-50 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Vintage Miner client KeyError crash on successful attestation

4 participants