fix(vintage-miner): use client.multiplier instead of missing evidence profile key (#7766)#7785
Conversation
FakerHideInBush
left a comment
There was a problem hiding this comment.
This PR makes the exact same single-line change as the already-open PRs #7767 and #7768 — all three modify vintage_miner/vintage_miner_client.py line 433 identically:
- print(f"Multiplier: {evidence['profile']['multiplier']}x")
+ print(f"Multiplier: {client.multiplier}x")With three PRs making the same change to the same line, only one can merge cleanly — the other two will either conflict or become no-ops. PR #7768 was flagged for duplication with #7767 in an earlier review; now #7785 creates a third copy.
Recommendation: Close this PR and PR #7768 in favor of PR #7767 (the earliest-opened version), or close all three and submit one consolidated PR that:
- Fixes the
evidence['profile']['multiplier']→client.multiplierdisplay bug - References the issue it closes (e.g.
Closes #7766) - Checks whether
client.multiplieris available at the call site in all code paths that invokeattest()
010ce68 to
fa37870
Compare
jaxint
left a comment
There was a problem hiding this comment.
Review Summary
This PR fixes vintage miner multiplier lookup.
Changes:
- Uses client.multiplier instead of missing evidence profile key
- Fixes KeyError for vintage miners without evidence profile
Quality:
- Simple, targeted fix
- Follows existing patterns
✅ APPROVED
RTC RewardThis merged PR earned 5 RTC — sent to |
Closes #7766
RTC wallet: RTCfe13452d122263caf633ab1876bd9631133b68b1
Changes
Testing