Skip to content

fix: use client.multiplier to avoid KeyError crash (#7766)#7768

Closed
lequangsang01 wants to merge 2 commits into
Scottcjn:mainfrom
lequangsang01:fix/bounty-7766
Closed

fix: use client.multiplier to avoid KeyError crash (#7766)#7768
lequangsang01 wants to merge 2 commits into
Scottcjn:mainfrom
lequangsang01:fix/bounty-7766

Conversation

@lequangsang01

Copy link
Copy Markdown
Contributor

Closes #7766

RTC wallet: RTCfe13452d122263caf633ab1876bd9631133b68b1

Changes

  • Fixed KeyError crash at line 433 by replacing evidence["profile"]["multiplier"] with client.multiplier
  • The evidence dict returned from submit_attestation() does not contain a multiplier key in profile

Testing

  • All tests pass

@github-actions github-actions Bot added BCOS-L1 Beacon Certified Open Source tier BCOS-L1 (required for non-doc PRs) size/XS PR: 1-10 lines labels Jun 30, 2026

@FakerHideInBush FakerHideInBush left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR makes the exact same single-line change as the already-open PR #7767 — both modify vintage_miner/vintage_miner_client.py line 433 from evidence['profile']['multiplier'] to client.multiplier.

The diff is byte-for-byte identical to PR #7767:

-            print(f"Multiplier: {evidence['profile']['multiplier']}x")
+            print(f"Multiplier: {client.multiplier}x")

Merging both will either produce a merge conflict (if the branch is not rebased after #7767 merges) or result in a no-op second merge. There should only be one PR for this fix.

Recommendation: Close this PR in favor of #7767 (or vice versa), or add the issue reference (Closes #7766) to PR #7767's description if that PR was filed without it — then close this one. The fix itself (client.multiplier instead of evidence['profile']['multiplier']) is correct; it just needs to land via one PR, not two.

@jaxint jaxint left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review by jaxint

Summary

Reviewed PR #7768: fix: use client.multiplier to avoid KeyError crash (#7766)

Code Analysis

Author: lequangsang01

Assessment

✅ Code review completed
✅ No blocking issues found

Verdict

APPROVE


Reviewer: jaxint
Wallet: AhqbFaPBPLMMiaLDzA9WhQcyvv4hMxiteLhPk3NhG1iG

@github-actions github-actions Bot added BCOS-L2 Beacon Certified Open Source tier BCOS-L2 (required for non-doc PRs) node Node server related api API endpoint related labels Jun 30, 2026
@Scottcjn

Scottcjn commented Jul 1, 2026

Copy link
Copy Markdown
Owner

Closing — #7766 KeyError already fixed via merged #7785. Appreciated; overlapped the merged one.

@Scottcjn Scottcjn closed this Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api API endpoint related BCOS-L1 Beacon Certified Open Source tier BCOS-L1 (required for non-doc PRs) BCOS-L2 Beacon Certified Open Source tier BCOS-L2 (required for non-doc PRs) node Node server related size/XS PR: 1-10 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Vintage Miner client KeyError crash on successful attestation

4 participants