Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(schema): Remove 'description' from required fields #4853

Merged
merged 2 commits into from
Apr 2, 2022

Conversation

niheaven
Copy link
Member

@niheaven niheaven commented Apr 1, 2022

Description

Don't require description in manifest since many user made manifests in user bucket may not have it.

Motivation and Context

Relates to #4528 (comment)

How Has This Been Tested?

Not suitable.

Checklist:

  • I have read the Contributing Guide.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

Copy link
Member

@rasa rasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty!

@niheaven niheaven merged commit f6679c2 into develop Apr 2, 2022
@niheaven niheaven deleted the fix-schema branch April 2, 2022 16:35
@chawyehsu
Copy link
Member

@niheaven Could you please fix the test? I'm encountering ci fault because of this.
https://github.com/ScoopInstaller/Scoop/blob/develop/test/Import-Bucket-Tests.ps1#L67

Fun fact that the test required description at the very beginning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants