Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: Add registry configuration #846

Merged
merged 2 commits into from
Mar 16, 2020
Merged

python: Add registry configuration #846

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57a22bd
python: Add .reg so installers find python (#128)
idbrii Feb 27, 2020
c7f0710
Use ascii encoding for .reg file
idbrii Mar 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
python: Add .reg so installers find python (#128) 
Fix #128.

PEP 514 specifies how python should be added to the registry so
third-party installers, binary packages depending on python (vim), and
pre-compiled binary extension packages (kivy, Pillow, PyGame) can find
python.

I think it also helps resolve python finding 32-bit vs 64-bit
executables.

Seems that python requires the "PythonCore" key. Testing with gvim:
    gvim +"py3 print(3)"
crashes with "Scoop" but works with "PythonCore". We're installing
python built by the Python Software Foundation, so it might be matching
that name somewhere inside of python.exe.

While regedit exports utf-16le, it correctly imports utf8.
  • Loading branch information
@idbrii
idbrii committed Mar 3, 2020
commit 57a22bdb383d0833377de4d30701ebc66d54b436
38 changes: 34 additions & 4 deletions bucket/python.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,46 @@
"description": "A programming language that lets you work quickly and integrate systems more effectively.",
"license": "Python-2.0",
"version": "3.8.2",
"notes": "Allow applications and third-party installers to find python by running: \"$dir\\install-pep-514.reg\"",
"architecture": {
"64bit": {
"url": "https://www.python.org/ftp/python/3.8.2/python-3.8.2-amd64.exe",
"hash": "8e400e3f32cdcb746e62e0db4d3ae4cba1f927141ebc4d0d5a4006b0daee8921"
"url": [
"https://raw.githubusercontent.com/ScoopInstaller/Main/master/scripts/python/install-pep-514.reg",
"https://raw.githubusercontent.com/ScoopInstaller/Main/master/scripts/python/uninstall-pep-514.reg",
"https://www.python.org/ftp/python/3.8.2/python-3.8.2-amd64.exe"
Ash258 marked this conversation as resolved.
Show resolved Hide resolved
],
"hash": [
"5d9d7a604c057e67973e1d4b3b488ae20a0e5ee5496d03b5cf091410e33e39ed",
"d9309423b693ed63aea6b1fbfc0c34f16842cdca22a1b3edef283b87567a53b9",
"8e400e3f32cdcb746e62e0db4d3ae4cba1f927141ebc4d0d5a4006b0daee8921"
]
},
"32bit": {
"url": "https://www.python.org/ftp/python/3.8.2/python-3.8.2.exe",
"hash": "03ac5754a69c9c11c08d1f4d694c14625a4d27348ad4dd2d1253e2547819db2c"
"url": [
"https://raw.githubusercontent.com/ScoopInstaller/Main/master/scripts/python/install-pep-514.reg",
"https://raw.githubusercontent.com/ScoopInstaller/Main/master/scripts/python/uninstall-pep-514.reg",
"https://www.python.org/ftp/python/3.8.2/python-3.8.2.exe"
Ash258 marked this conversation as resolved.
Show resolved Hide resolved
],
"hash": [
"5d9d7a604c057e67973e1d4b3b488ae20a0e5ee5496d03b5cf091410e33e39ed",
"d9309423b693ed63aea6b1fbfc0c34f16842cdca22a1b3edef283b87567a53b9",
"03ac5754a69c9c11c08d1f4d694c14625a4d27348ad4dd2d1253e2547819db2c"
]
}
},
"pre_install": [
"'install-pep-514.reg', 'uninstall-pep-514.reg' | ForEach-Object {",
" $py_root = \"$dir\".Replace('\\', '\\\\')",
" $py_version = ($version -split '\\.')[0..1] -join '.'",
" $content = Get-Content \"$dir\\$_\"",
" $content = $content.Replace('$py_root', $py_root)",
" $content = $content.Replace('$py_version', $py_version)",
" if ($global) {",
" $content = $content.Replace('HKEY_CURRENT_USER', 'HKEY_LOCAL_MACHINE')",
" }",
" Set-Content \"$dir\\$_\" $content -Encoding UTF8",
idbrii marked this conversation as resolved.
Show resolved Hide resolved
"}"
],
"installer": {
"script": [
"Expand-DarkArchive \"$dir\\$fname\" \"$dir\\_tmp\"",
Expand Down
17 changes: 17 additions & 0 deletions scripts/python/install-pep-514.reg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
Windows Registry Editor Version 5.00

[HKEY_CURRENT_USER\Software\Python\PythonCore]
"DisplayName"="Official Python installed with Scoop"
Ash258 marked this conversation as resolved.
Show resolved Hide resolved
"SupportUrl"="https://www.python.org/"

[HKEY_CURRENT_USER\Software\Python\PythonCore\$py_version]
"DisplayName"="Python $py_version"

[HKEY_CURRENT_USER\Software\Python\PythonCore\$py_version\InstallPath]
@="$py_root"
"ExecutablePath"="$py_root\\python.exe"
"WindowedExecutablePath"="$py_root\\pythonw.exe"

[HKEY_CURRENT_USER\Software\Python\PythonCore\$py_version\PythonPath]
@="$py_root\\Lib\\;$py_root\\DLLs\\"

3 changes: 3 additions & 0 deletions scripts/python/uninstall-pep-514.reg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Windows Registry Editor Version 5.00

[-HKEY_CURRENT_USER\Software\Python\PythonCore]
idbrii marked this conversation as resolved.
Show resolved Hide resolved