-
-
Notifications
You must be signed in to change notification settings - Fork 977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python: Add registry configuration #846
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Works great on my testing branch:
|
Ash258
suggested changes
Feb 28, 2020
Ash258
changed the title
python: Add .reg so installers find python (#128)
python: Add registry configuration
Feb 28, 2020
idbrii
force-pushed
the
py-registry
branch
2 times, most recently
from
February 28, 2020 23:24
d0017f2
to
c39b0f6
Compare
Ash258
suggested changes
Feb 29, 2020
Ash258
suggested changes
Mar 3, 2020
Fix ScoopInstaller#128. PEP 514 specifies how python should be added to the registry so third-party installers, binary packages depending on python (vim), and pre-compiled binary extension packages (kivy, Pillow, PyGame) can find python. I think it also helps resolve python finding 32-bit vs 64-bit executables. Seems that python requires the "PythonCore" key. Testing with gvim: gvim +"py3 print(3)" crashes with "Scoop" but works with "PythonCore". We're installing python built by the Python Software Foundation, so it might be matching that name somewhere inside of python.exe. While regedit exports utf-16le, it correctly imports utf8.
Co-Authored-By: Jakub Čábera <cabera.jakub@gmail.com>
Ash258
approved these changes
Mar 9, 2020
r15ch13
added a commit
that referenced
this pull request
May 14, 2020
Fixes errors introduced by #846 closes #1088 closes ScoopInstaller/Scoop#3973 closes #1089 closes #1090
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PEP 514 specifies how python should be added to the registry so
third-party installers, binary packages depending on python (vim), and
pre-compiled binary extension packages (kivy, Pillow, PyGame) can find
python.
I think it also helps resolve python finding 32-bit vs 64-bit
executables.
Seems that python requires the "PythonCore" key. Testing with gvim:
gvim +"py3 print(3)"
crashes with "Scoop" but works with "PythonCore". We're installing
python built by the Python Software Foundation, so it might be matching
that name somewhere inside of python.exe.
Since the manifest uses github urls, it won't work until merged into master. If you want to check it out, I made a testing branch that points to itself.