-
Notifications
You must be signed in to change notification settings - Fork 19
Auto labels for PR's and issues #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pr_labels * 'main' of github.com:HGWright/python-stratify: testing auto-label gha 16 testing auto-label gha 15 testing auto-label gha 14 testing auto-label gha 13 testing auto-label gha 12 testing auto-label gha 11 testing auto-label gha 10 testing auto-label gha 9 testing auto-label gha 8 testing auto-label gha 7 testing auto-label gha 6 testing auto-label gha 5 testing auto-label gha 4 testing auto-label gha 3 testing auto-label gha 2 testing auto-label gha essage
…pr_labels * 'main' of github.com:SciTools/python-stratify: Updated environment lockfiles (SciTools#129) adopting sort-all pre-commit git hook (SciTools#128) Updated environment lockfiles (SciTools#127) Bump scitools/workflows from 2023.05.0 to 2023.06.0 (SciTools#126) Bump pypa/cibuildwheel from 2.13.0 to 2.13.1 (SciTools#125) Updated environment lockfiles (SciTools#124) adding a CITATION.cff and a GHA to check it (SciTools#123) Updated environment lockfiles (SciTools#122) Adding a GHA to check for stale issues and pull-requests (SciTools#120) Rebase to upstream
Closed
Closed
bjlittle
requested changes
Jun 30, 2023
Member
bjlittle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HGWright This looks great! 💯
Just a simple question to clarify, then we can bank this and start auto-labeling 🎉
bjlittle
approved these changes
Jul 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
This PR adds an auto labeling gha that will label both issues and PR's. It does this by either looking at the files changed or the text within the titles and body of the issue/PR. If it finds certain predefined words it will add the corresponding label.
I have made a couple of extra labels for the repo as I felt they were missing from the current list. part of #106
I have tested this on my personal fork and it seems to work as expected. It runs on the opening, reopening or editing of the issue/pr.
I think a follow on from this PR is to think about updating the templates for issues and PR's. I have not done this here but am interested in your thoughts on my current thoughts about this.
Currently I think not updating them is the best option and maybe expand the list of words so that most people will accidently trigger the correct labels. The whole point is that they are supposed to be automated so making the auther tailor their PR to the labeller defeats the point of the automation.
I think expanding the list of words is probably necessary for this because the reference words are case sensitive so this could make them not trigger with we would want them too