Skip to content

Conversation

@HGWright
Copy link
Contributor

@HGWright HGWright commented Jun 27, 2023

🚀 Pull Request

Description

This PR adds an auto labeling gha that will label both issues and PR's. It does this by either looking at the files changed or the text within the titles and body of the issue/PR. If it finds certain predefined words it will add the corresponding label.

I have made a couple of extra labels for the repo as I felt they were missing from the current list. part of #106

I have tested this on my personal fork and it seems to work as expected. It runs on the opening, reopening or editing of the issue/pr.

I think a follow on from this PR is to think about updating the templates for issues and PR's. I have not done this here but am interested in your thoughts on my current thoughts about this.

Currently I think not updating them is the best option and maybe expand the list of words so that most people will accidently trigger the correct labels. The whole point is that they are supposed to be automated so making the auther tailor their PR to the labeller defeats the point of the automation.

I think expanding the list of words is probably necessary for this because the reference words are case sensitive so this could make them not trigger with we would want them too


HGWright added 18 commits June 26, 2023 14:40
…pr_labels

* 'main' of github.com:HGWright/python-stratify:
  testing auto-label gha 16
  testing auto-label gha 15
  testing auto-label gha 14
  testing auto-label gha 13
  testing auto-label gha 12
  testing auto-label gha 11
  testing auto-label gha 10
  testing auto-label gha 9
  testing auto-label gha 8
  testing auto-label gha 7
  testing auto-label gha 6
  testing auto-label gha 5
  testing auto-label gha 4
  testing auto-label gha 3
  testing auto-label gha 2
  testing auto-label gha
essage
…pr_labels

* 'main' of github.com:SciTools/python-stratify:
  Updated environment lockfiles (SciTools#129)
  adopting sort-all pre-commit git hook (SciTools#128)
  Updated environment lockfiles (SciTools#127)
  Bump scitools/workflows from 2023.05.0 to 2023.06.0 (SciTools#126)
  Bump pypa/cibuildwheel from 2.13.0 to 2.13.1 (SciTools#125)
  Updated environment lockfiles (SciTools#124)
  adding a CITATION.cff and a GHA to check it (SciTools#123)
  Updated environment lockfiles (SciTools#122)
  Adding a GHA to check for stale issues and pull-requests (SciTools#120)

Rebase to upstream
@HGWright HGWright requested a review from bjlittle June 27, 2023 13:18
@HGWright HGWright changed the title Auto pr labels Auto labels for PR's and issues Jun 27, 2023
@bjlittle bjlittle self-assigned this Jun 27, 2023
@HGWright HGWright linked an issue Jun 29, 2023 that may be closed by this pull request
@HGWright HGWright removed a link to an issue Jun 29, 2023
Copy link
Member

@bjlittle bjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HGWright This looks great! 💯

Just a simple question to clarify, then we can bank this and start auto-labeling 🎉

@bjlittle bjlittle merged commit fd2c211 into SciTools:main Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants