Skip to content

Conversation

@HGWright
Copy link
Contributor

🚀 Pull Request

Description

Adopts the sort-all pre-commit git hook. Added into the pre-commit-config.yaml.

This sorts all list alphabetically.

It also is the only addition from the review in #94.


@HGWright HGWright requested a review from bjlittle June 23, 2023 10:40
@bjlittle bjlittle self-assigned this Jun 23, 2023
@bjlittle
Copy link
Member

@HGWright The ci-wheels for osx isn't happy... might just be a pip caching issue, dunno

Copy link
Member

@bjlittle bjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HGWright Awesome! Looks good to me mate 🍻

@bjlittle bjlittle merged commit fc4b1d5 into SciTools:main Jun 23, 2023
@HGWright
Copy link
Contributor Author

@HGWright The ci-wheels for osx isn't happy... might just be a pip caching issue, dunno

Fixed after a simple re-run

@HGWright HGWright mentioned this pull request Jun 23, 2023
1 task
HGWright added a commit to HGWright/python-stratify that referenced this pull request Jun 27, 2023
…pr_labels

* 'main' of github.com:SciTools/python-stratify:
  Updated environment lockfiles (SciTools#129)
  adopting sort-all pre-commit git hook (SciTools#128)
  Updated environment lockfiles (SciTools#127)
  Bump scitools/workflows from 2023.05.0 to 2023.06.0 (SciTools#126)
  Bump pypa/cibuildwheel from 2.13.0 to 2.13.1 (SciTools#125)
  Updated environment lockfiles (SciTools#124)
  adding a CITATION.cff and a GHA to check it (SciTools#123)
  Updated environment lockfiles (SciTools#122)
  Adding a GHA to check for stale issues and pull-requests (SciTools#120)

Rebase to upstream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants