Skip to content

Use https for opendap.org link, as http no longer supported. #5628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 12, 2023
Merged

Use https for opendap.org link, as http no longer supported. #5628

merged 2 commits into from
Dec 12, 2023

Conversation

pp-mo
Copy link
Member

@pp-mo pp-mo commented Dec 12, 2023

Should fix #5619 CI linkcheck failure

@codecov Codecov
Copy link

codecov bot commented Dec 12, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (72b56ec) 89.69% compared to head (e645d97) 89.69%.

❗ Current head e645d97 differs from pull request most recent head 2a5ac81. Consider uploading reports for the commit 2a5ac81 to get more accurate results

Additional details and impacted files 
@@                  Coverage Diff                   @@
##           auto-update-lockfiles    #5628   +/-   ##
======================================================
  Coverage                  89.69%   89.69%           
======================================================
  Files                         90       90           
  Lines                      22807    22807           
  Branches                    5441     5441           
======================================================
  Hits                       20456    20456           
  Misses                      1618     1618           
  Partials                     733      733

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pp-mo
Copy link
Member Author

pp-mo commented Dec 12, 2023

Hang on, now failed elsewhere, on the twitter link.
But I think that may be a one-off
Trying a re-spin ...

@bjlittle
Copy link
Member

bjlittle commented Dec 12, 2023 •
edited
Loading

Hang on, now failed elsewhere, on the twitter link. But I think that may be a one-off Trying a re-spin ...

@pp-mo I've been respinning various iris PR with this failure ... I'm tempted to suggest that you add the twitter link to the docs/src/conf.py to ignore as part of the linkcheck.

What say ye?

@bjlittle bjlittle self-assigned this Dec 12, 2023
@bjlittle bjlittle self-requested a review December 12, 2023 13:39
bjlittle
bjlittle requested changes Dec 12, 2023
View reviewed changes
Copy link
Member

@bjlittle bjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the twitter link to the list of exceptions in the docs/src/conf.py as it's giving us serious issues atm

@bjlittle
Copy link
Member

@pp-mo Have you rebased from main after #5621 landed?

@pp-mo
Copy link
Member Author

pp-mo commented Dec 12, 2023 •
edited
Loading

@pp-mo Have you rebased from main after #5621 landed?

No, this PR is not independent as it targets auto-update-lockfiles
i.e. it is a fix for #5619

@bjlittle bjlittle merged commit dcf381f into SciTools:auto-update-lockfiles Dec 12, 2023
@pp-mo
Copy link
Member Author

pp-mo commented Dec 12, 2023 •
edited
Loading

Ok these 2 changes do seem to work around the problem.

@bjlittle is it good to merge this + #5619
or, given your comments above about "rebased from main after #5621 landed", is it better to launch a fresh PR, based on a more recent main ?

pp-mo added a commit that referenced this pull request Dec 12, 2023
@scitools-ci @web-flow @pp-mo
[CI Bot] environment lockfiles auto-update (#5619)
b80ff4d 
* Updated environment lockfiles

* Use https for opendap.org link, as http no longer supported. (#5628)

* Use https for opendap.org link, as http no longer supported.

* Exclude twitter/scitools_iris from linkcheck, now failing for some unknown reason.

---------

Co-authored-by: Lockfile bot <noreply@github.com>
Co-authored-by: Patrick Peglar <patrick.peglar@metoffice.gov.uk>
@pp-mo pp-mo deleted the fix_opendap_link branch December 10, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjlittle bjlittle bjlittle approved these changes

Assignees

@bjlittle bjlittle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pp-mo @bjlittle