Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update links to https #5621

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented Dec 11, 2023

🚀 Pull Request

Description

Update http:// links to https:// to fix the failing link check.


Consult Iris pull request check list

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8694479) 89.69% compared to head (60e1565) 89.69%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5621   +/-   ##
=======================================
  Coverage   89.69%   89.69%           
=======================================
  Files          90       90           
  Lines       22807    22807           
  Branches     5441     5441           
=======================================
  Hits        20456    20456           
  Misses       1618     1618           
  Partials      733      733           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bouweandela bouweandela marked this pull request as ready for review December 11, 2023 10:42
@bjlittle bjlittle self-assigned this Dec 11, 2023
@bjlittle bjlittle self-requested a review December 11, 2023 15:15
Copy link
Member

@bjlittle bjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bouweandela Brilliant, thanks 🍻

I'm going to bank this now as-is so that we can unblock main.

Would you mind creating a follow-up PR with a whatsnew entry, thanks 👍

@bjlittle bjlittle merged commit 1e1a215 into SciTools:main Dec 11, 2023
@bouweandela bouweandela deleted the update-links-to-https branch December 11, 2023 17:19
@bouweandela
Copy link
Member Author

Sorry, I forgot about the whatsnew system, I will make a new pull request to add it.

tkknight added a commit to tkknight/iris that referenced this pull request Dec 13, 2023
* main:
  Adopt inital noop ruff linter (SciTools#5623)
  Update links to https (SciTools#5621)
  Bump actions/stale from 8 to 9 (SciTools#5616)
  Faster and simpler iris.util.array_equal (SciTools#5610)
  Updated environment lockfiles (SciTools#5608)
  Bump actions/setup-python from 4 to 5 (SciTools#5614)
  Possible citation updates -- not clear whether appropriate. (SciTools#5453)
  Whats new updates for v3.7.0 . (SciTools#5451)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants