Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update pre-commit hooks #571

Merged
merged 2 commits into from
Apr 8, 2025
Merged

chore: update pre-commit hooks #571

merged 2 commits into from
Apr 8, 2025

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Mar 17, 2025

@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from acda0be to 48ded74 Compare March 17, 2025 17:37
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.40%. Comparing base (70131ce) to head (a7e828c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #571   +/-   ##
=======================================
  Coverage   58.40%   58.40%           
=======================================
  Files          62       62           
  Lines        6433     6433           
  Branches     1150     1150           
=======================================
  Hits         3757     3757           
  Misses       2385     2385           
  Partials      291      291           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 48ded74 to e34bef4 Compare March 24, 2025 17:34
pp-mo
pp-mo previously approved these changes Mar 25, 2025
@pp-mo
Copy link
Member

pp-mo commented Apr 3, 2025

NOTE:

re-spun checks, and the error on the main tests has now passed off.
We now have a pre-commit failure, which however is entirely comprehensible.

@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from f6b5e25 to c5ca3f6 Compare April 7, 2025 17:43
Copy link
Contributor

@scitools-ci scitools-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Templating

Version numbers are not typically covered by templating. It is expected that this PR is 100% about advancing version numbers, which would not require any templating follow-up. Please double-check for any other changes that might be suitable for templating.

pre-commit-ci bot and others added 2 commits April 8, 2025 14:14
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.9.10 → v0.11.2](astral-sh/ruff-pre-commit@v0.9.10...v0.11.2)
- [github.com/abravalheri/validate-pyproject: v0.23 → v0.24.1](abravalheri/validate-pyproject@v0.23...v0.24.1)
Copy link

@ESadek-MO ESadek-MO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see SciTools/.github#77

@ESadek-MO ESadek-MO dismissed their stale review April 8, 2025 15:43

Changes were just merging in PR, didn't affect actual template

Copy link
Member

@pp-mo pp-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK now I believe!
Thanks to @ESadek-MO SciTools/.github#78

@pp-mo pp-mo merged commit 5824913 into main Apr 8, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants