Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensured any bot PRs will assign humans to issues #78

Merged
merged 6 commits into from
Apr 8, 2025

Conversation

ESadek-MO
Copy link
Contributor

@ESadek-MO ESadek-MO commented Apr 8, 2025

See SciTools/cf-units#571 for evidence it works.

I couldn't create an issue to test 69dadac, due to the nature of the code, but I beleive the functionality is the same.

@ESadek-MO ESadek-MO changed the title Local update Ensured any bot PRs will assign humans to issues Apr 8, 2025
@ESadek-MO ESadek-MO marked this pull request as ready for review April 8, 2025 14:16
Copy link
Member

@pp-mo pp-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny change

As discussed, I found this a bit confusing + was going to suggest some changes to hopefully make the code logic clearer.
But, from discussion, that should be left to another time. So maybe I'll propose that after if I can come up with something,

Co-authored-by: Patrick Peglar <patrick.peglar@metoffice.gov.uk>
@pp-mo pp-mo merged commit e7e006b into SciTools:main Apr 8, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants