Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use initialization_data instead of initializeprob, etc. #838

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

refactor: use initialization_data instead of initializeprob, etc. #838

wants to merge 5 commits into from
+128 −82

Commits on Oct 30, 2024

  1. feat: add OverrideInitData

    @AayushSabharwal
    AayushSabharwal committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    de94f4e View commit details
    Browse the repository at this point in the history

  2. refactor: use initialization_data instead of initializeprob, etc.

    @AayushSabharwal
    AayushSabharwal committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    59a0a89 View commit details
    Browse the repository at this point in the history

  3. fix: add getproperty method for backwards compatibility

    @AayushSabharwal
    AayushSabharwal committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    669cbd3 View commit details
    Browse the repository at this point in the history

  4. fix: reorder SplitFunction fields to avoid breaking change 

    The existing syntax is `initializeprob, ..., nlprob`. Trying to add
`initialization_data` in the middle breaks the non-kwarg-only method.
Putting it at the end fixes this issue. Anything old still has the order
it relies on, with `initialization_data` defaulting to `nothing`, and
anything new would just have to provide the redundant kwargs if it needs
to specify `initialization_data`.
    @AayushSabharwal
    AayushSabharwal committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    3c5327d View commit details
    Browse the repository at this point in the history

  5. fix: move initializeprob typeasserts to OverrideInitData

    @AayushSabharwal
    AayushSabharwal committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    b4cce5b View commit details
    Browse the repository at this point in the history