Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use initialization_data instead of initializeprob, etc. #838

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

AayushSabharwal
Copy link
Member

@AayushSabharwal AayushSabharwal commented Oct 30, 2024

This is in preparation for moving OverrideInit and CheckInit to SciMLBase

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@ChrisRackauckas
Copy link
Member

This is breaking to downstream though if the CheckInit and OverrideInit isn't also changed?

@AayushSabharwal
Copy link
Member Author

I forgot to overload getproperty. That should stop it from being breaking.

The existing syntax is `initializeprob, ..., nlprob`. Trying to add
`initialization_data` in the middle breaks the non-kwarg-only method.
Putting it at the end fixes this issue. Anything old still has the order
it relies on, with `initialization_data` defaulting to `nothing`, and
anything new would just have to provide the redundant kwargs if it needs
to specify `initialization_data`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants