Skip to content

Conversation

@lenaploetzke
Copy link
Member

@lenaploetzke lenaploetzke commented Feb 20, 2024

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • Added flow chart to the README of the LCT model, extended the explanation of the model and added a table for the parameters.
  • Two arrows in the diagram for the ODE SECIR model have been swapped because they were mixed up.

If need be, add additional information and what the reviewer should look out for in particular:

  • Also made a small change to the parameter table in the README for the ODE SECIR model.

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #928

@lenaploetzke lenaploetzke added class::documentation Improvements or additions to documentation model::lct Models using the linear chain trick labels Feb 20, 2024
@lenaploetzke lenaploetzke self-assigned this Feb 20, 2024
@lenaploetzke lenaploetzke linked an issue Feb 20, 2024 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.22%. Comparing base (105816d) to head (788769a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #943   +/-   ##
=======================================
  Coverage   96.22%   96.22%           
=======================================
  Files         124      124           
  Lines        9699     9699           
=======================================
  Hits         9333     9333           
  Misses        366      366           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lenaploetzke lenaploetzke requested a review from HenrZu February 21, 2024 09:06
@lenaploetzke lenaploetzke added the status::in review This issues is in review. label Feb 21, 2024
@lenaploetzke lenaploetzke requested a review from HenrZu February 23, 2024 09:25
@HenrZu HenrZu merged commit c484b89 into main Feb 26, 2024
@HenrZu HenrZu deleted the 928-add-a-flow-chart-for-the-lct-model branch February 26, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

class::documentation Improvements or additions to documentation model::lct Models using the linear chain trick status::in review This issues is in review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a flow chart for the LCT model

3 participants