Skip to content

Conversation

@HenrZu
Copy link
Contributor

@HenrZu HenrZu commented Feb 3, 2023

Merge Request - GuideLine Checklist

Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.

Checks by code author:

Always to be checked:

If functions were changed or functionality was added:

  • Tests for new functionality has been added
  • A local test was succesful

If new functionality was added:

  • There is appropriate documentation of your work. (use doxygen style comments)

If new third party software is used:

  • Did you pay attention to its license? Please remember to add it to the wiki after successful merging.

If new mathematical methods or epidemiological terms are used:

  • Are new methods referenced? Did you provide further documentation? Has the glossary been updated?

The following questions are addressed in the documentation if need be:

  • Developers (what did you do?, how can it be maintained?)

  • For users (how to use your work?)

  • For admins (how to install and configure your work?)

  • For documentation: Please write or update the Readme in the current working directory!

Checks by code reviewer(s):

  • Is the code clean of development artifacts e.g., unnecessary comments, prints, ...
  • The ticket goals for each associated issue are reached or problems are clearly addressed (i.e., a new issue was introduced).
  • There are appropriate unit tests and they pass.
  • The git history is clean and linearized for the merge request. All reviewers should squash commits and write a simple and meaningful commit message.
  • Coverage report for new code is acceptable.

Closes #402, Closes #403

@HenrZu HenrZu changed the title structure secir with groups 402 Surrogate model implementation with multiple age groups and dampings Feb 3, 2023
@HenrZu HenrZu marked this pull request as ready for review April 14, 2023 12:28
@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3b8cf9d) 95.50% compared to head (88117a8) 95.60%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #562      +/-   ##
==========================================
+ Coverage   95.50%   95.60%   +0.10%     
==========================================
  Files         118      118              
  Lines        9297     9448     +151     
==========================================
+ Hits         8879     9033     +154     
+ Misses        418      415       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HenrZu HenrZu requested a review from mknaranja April 14, 2023 14:01
@HenrZu HenrZu requested review from jubicker and removed request for mknaranja October 4, 2023 13:26
HenrZu and others added 5 commits January 4, 2024 08:09
Co-authored-by: jubicker <113909589+jubicker@users.noreply.github.com>
Co-authored-by: Martin J. Kühn <62713180+mknaranja@users.noreply.github.com>
@HenrZu HenrZu requested a review from jubicker January 8, 2024 08:52
HenrZu and others added 2 commits January 12, 2024 09:02
…_groups/network_architectures.py

Co-authored-by: jubicker <113909589+jubicker@users.noreply.github.com>
@HenrZu HenrZu requested a review from jubicker January 12, 2024 11:15
@HenrZu HenrZu merged commit fe6109c into main Jan 12, 2024
@HenrZu HenrZu deleted the 402-Neural-net-for-multiple-age-groups branch January 12, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Predict the development of the pandemic after one damping at a fixed day Neural net for multiple age groups

6 participants