Skip to content

Conversation

@HenrZu
Copy link
Contributor

@HenrZu HenrZu commented Apr 16, 2025

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • Since Ubuntu 20.04 was retired, we had to update our min versions for the CI.
  • Now: Min: 22.04/ latest 24.04
  • update Compiler (GCC, Clang) versions

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

@HenrZu HenrZu linked an issue Apr 16, 2025 that may be closed by this pull request
2 tasks
@codecov
Copy link

codecov bot commented Apr 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.21%. Comparing base (3390762) to head (b1f86bb).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1257      +/-   ##
==========================================
- Coverage   97.23%   97.21%   -0.02%     
==========================================
  Files         155      156       +1     
  Lines       14282    14674     +392     
==========================================
+ Hits        13887    14266     +379     
- Misses        395      408      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@HenrZu
Copy link
Contributor Author

HenrZu commented Apr 22, 2025

A test of the generation package is still failing and will therefore be skipped for now. Moved to Issue #1261.

@HenrZu HenrZu requested a review from reneSchm April 22, 2025 07:38
Copy link
Member

@reneSchm reneSchm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the warnings on the death tests should be fixed, but otherwise this looks like a fair solution.

@HenrZu HenrZu merged commit 7be189b into main Apr 23, 2025
58 checks passed
@HenrZu HenrZu deleted the 1256-update-ubuntu-version branch April 23, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ubuntu 20.04 retirement affects our CI

4 participants