Skip to content

Conversation

@annawendler
Copy link
Member

@annawendler annawendler commented Jan 7, 2025

Changes and Information

  • m_transitions was renamed to transitions
  • m_populations was renamed to populations
  • m_total_confirmed_cases was renamed to total_confirmed_cases
  • Arguments of model constructor were partially renamed for better understanding

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #1132

@annawendler annawendler linked an issue Jan 7, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.98%. Comparing base (0c4965a) to head (79bd228).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1173      +/-   ##
==========================================
+ Coverage   96.97%   96.98%   +0.01%     
==========================================
  Files         148      148              
  Lines       13718    13782      +64     
==========================================
+ Hits        13303    13367      +64     
  Misses        415      415              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@annawendler
Copy link
Member Author

I changed the name m_transitions to flows because it is in line with our simulation functions where we also use the term flow. The term transition (e.g. in transition_idx) still occurs in some places when we are referring to the transitions themselves and not to the number of individuals transitioning from one compartment to another.

Copy link
Member

@lenaploetzke lenaploetzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Please consider especially to rename the InfectionTransisitons and the TransitionDistributions consistent to the flows TimeSeries.

Copy link
Member

@lenaploetzke lenaploetzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best solution for now 👍

@annawendler annawendler merged commit bae6709 into main Jan 21, 2025
58 checks passed
@annawendler annawendler deleted the 1132-rename-public-members-in-ide-model branch January 21, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename public members in IDE model

3 participants