-
Notifications
You must be signed in to change notification settings - Fork 19
1132 Rename public members of IDE model #1173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1173 +/- ##
==========================================
+ Coverage 96.97% 96.98% +0.01%
==========================================
Files 148 148
Lines 13718 13782 +64
==========================================
+ Hits 13303 13367 +64
Misses 415 415 ☔ View full report in Codecov by Sentry. |
|
I changed the name m_transitions to flows because it is in line with our simulation functions where we also use the term flow. The term transition (e.g. in transition_idx) still occurs in some places when we are referring to the transitions themselves and not to the number of individuals transitioning from one compartment to another. |
lenaploetzke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Please consider especially to rename the InfectionTransisitons and the TransitionDistributions consistent to the flows TimeSeries.
lenaploetzke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Best solution for now 👍
Changes and Information
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)
Closes #1132