CircleCI: resource_class moved to additionalProperties section #1266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CircleCi config 2.1 (https://circleci.com/docs/2.0/configuration-reference/#executors-requires-version-21) defines resource_class on the executor level, not docker. Additionally, resource_class enum extended to values defined in circleci reference.
miqm
changed the title
|
@madskristensen - could you take a look at this? This PR fixes ugly error in Visual Studio Code when executors node is complaining on missing docker entry. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CircleCi config 2.1 (https://circleci.com/docs/2.0/configuration-reference/#executors-requires-version-21) defines resource_class on the executor level, not docker.
Additionally, resource_class enum extended to values defined in circleci reference.
Fixes redhat-developer/vscode-yaml#370