circleci 2.1 executors not supported

[lqueryvg]

Example taken from: https://circleci.com/docs/2.0/configuration-reference/#executors-requires-version-21

version: 2.1
executors:
  my-executor:
    docker:
      - image: circleci/ruby:2.5.1-node-browsers

jobs:
  my-job:
    executor: my-executor
    steps:
      - run: echo outside the executor

The current result in vscode is that my-job gets highlighted as an error with the tool tip: Missing property "docker".

[chaz8080]

Issue in file: https://github.com/SchemaStore/schemastore/blob/dd5a38ce426e2f1ee2be13cfe4f20b6c3051d127/src/schemas/json/circleciconfig.json

lines 421-428

        "oneOf": [
          {
            "type": "object",
            "required": ["docker"],
            "properties": {
              "docker": {
                "description":
                  "Options for [docker executor](https://circleci.com/docs/2.0/configuration-reference/#docker)",

I'm not sure if anything else needs to happen, but it looks like the "required": ["docker"], field just needs to be removed? Or maybe a check for docker or executor block?

[nakkurt]

Any updates on this issue?

[kkarimi]

+1

[heiwais25]

+1

[chaz8080]

Related to #515

[miqm]

I created a PR #1266 that most probably fixes this issue, although I didn't test it (yet) with vscode.

[jrdnbradford]

@lqueryvg and @hyperupcall this appears to have been fixed by #1266 and can be closed.

[hyperupcall]

I tested the code snippet, and it passes validation locally, so it doesn't appear to be an issue with unsupported executors. The issue likely seems to be due to a buggy schema validator - the "required": ["docker"] seemed to be "cascading up" to the oneOf block. I don't think it's related to #1266, though

I'm still closing this issue since this issue is old, and i'm not able to reproduce it anymore - it's likely to be an implementation issue. I did consider removing the required: ["docker"] (and similar properties) from the schema, but this sort of required pattern is used throughout the schema, and removing it would make things more irregular.

If people are still encountering this issue in 2024, please let me know, and I'll reopen.