feat: when osc visibility is set to always, apply osc margins to show menus above it#303
Merged
feat: when osc visibility is set to always, apply osc margins to show menus above it#303
Conversation
Since request_init() was used to update (not sure why), it stopped working after its removal. But simply letting the content function handle it resolves the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #302
visibility=always1000instead of-1request_init()calls withinosc_init()osc_init()cache_enabled()helperrequest_init()was used to update it (not sure why), it stopped working after its removal. Simply letting the content function handle it resolves the issue.cache_infotooltip on hover using the new cache helper function