When osc visibility is set to always, apply margins to show select menus above it

[Samillion]

Expected behavior of the wanted feature

At the moment, all the interactive menus console/select force the OSC to hide.

It was implemented like that so that console or select don't overlap with the OSC itself. It works, but it's not the best solution.

A better implementation is to introduce osc margins, so that it draws console/select above the OSC if it's visible, and once OSC hides, it moves down.

This follows mpv's stock OSC implementation, and we wouldn't need to assign a z depth of -1 to draw the osc behind everything.

Which should also follow the pending PR at mpv to improve console/select: mpv-player/mpv#15676

[Samillion]

Test script: osc_margins/modernz.lua
Commit: b934b13

Changes:

• Don't force OSC to hide with interactive menus
• Use osc margins to show interactive menus above osc, when it's visible
• Change z depth of OSC to 1000 instead of -1

CC: @Keith94 since you asked for this a while ago in #265

[Samillion]

Known issue:

• When osc is visible, update_margins() is spammed (verbose)

Cause:

• Calling update_margins() in osc_init() causes the verbose spam.

[Samillion]

Updated: osc_margins/modernz.lua
Commit: 9b3c1d0

Changes:

• When osc is visible, don't spam margins (verbose)

[Samillion]

If all is working well, should the OSC be forced to hide or leave it as it is now? moves up/down depending on osc visibility.

As a default behavior I mean.

[Keith94]

Using script-message-to modernz osc-hide feels like a better UX.

Not a fan of the shifting up/down personally

[Samillion]

Noted, will add them back soon.

Now at least it covers all scenarios like the one you reported a while ago with chapters or even with console and not just select.

[Keith94]

It makes sense to draw it above the osc like this when you're using visibility=always though. That would be a good change.

[Samillion]

Indeed.

Updated: osc_margins/modernz.lua
Commit: cbc4c8b

Changes:

• Hide osc when showing interactive menus

[Samillion]

It makes sense to draw it above the osc like this when you're using visibility=always though. That would be a good change.

That's actually a great point. If visibility is always, then interactive menus shouldn't force osc hide.

[Samillion]

Updated: osc_margins/modernz.lua
Commit: fe3272a

Changes:

• Don't force hide osc with menus if osc visibility is set to always (ie: only with auto)

[Samillion]

I'll wait a day or so before merging, just to make sure everything is working well.

[Keith94]

I'm getting the "sometimes it works, sometimes it doesn't" behavior xD