optimize ProcessListVRS to reuse existing Hours if possible. Issue #154 #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
make sure to look at the diff with ?w=0 to ignore whitespace/tab changes |
added 9 commits
November 28, 2016 14:59
…pace changes because I had to switch to using dev console.
…is (i.e., whether to re-evaluate all shifts or just future shifts)
… and 2) reuse existing hours rather than always deleting and recreating hours.
…ot just future ones.
|
@njjc @jjbennett This pull request is ready for review. I've added a bunch of new tests to make sure VRS's and JRS's act as expected. This is a non-trivial code change, so I wonder if we want to set up a meeting to review the code together, rather than just looking at these diffs. If we meet, probably worth having both of you involved. |
|
@davidhabib Ran a few manual tests and everything seems to function as advertised. This would be a great feature for @jessingrass to put through the wringer at some point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Critical Changes
Changes
The scheduler has been optimized to only evaluate future Volunteer Shifts when processing Job Recurrence Schedules and Volunteer Recurrence Schedules, rather than also evaluating past Volunteer Shifts.
The scheduler will now reuse existing Volunteer Hours when processing Job Recurrence Schedules and Volunteer Recurrence Schedules. For Volunteer Hours that already exist on past Volunteer Shifts, the Volunteer Hours will be left alone and no fields, including Status, will be changed. For existing Volunteer Hours on future Volunteer Shifts, fields will be updated as specified in the Volunteer Recurrence Schedule.
Issues Closed
Fixes #154
Fixes #208